add info callout for s3 datasources #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
paulstn
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
anirudha and
sumukhswamy
as code owners
ps48
approved these changes
Mar 19, 2024
YANG-DB
approved these changes
Mar 19, 2024
Signed-off-by: Paul Sebastian <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1575 +/- ##
==========================================
- Coverage 57.84% 57.83% -0.01%
==========================================
Files 367 367
Lines 13760 13769 +9
Branches 3603 3609 +6
==========================================
+ Hits 7959 7963 +4
- Misses 5738 5742 +4
- Partials 63 64 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mengweieric
approved these changes
Mar 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
* add callout for s3 datasources Signed-off-by: Paul Sebastian <[email protected]> * fix linting Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]> (cherry picked from commit a0e7e36) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
YANG-DB
approved these changes
Mar 20, 2024
YANG-DB
approved these changes
Mar 20, 2024
ps48
pushed a commit
that referenced
this pull request
Mar 20, 2024
* add callout for s3 datasources * fix linting --------- (cherry picked from commit a0e7e36) Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
* add callout for s3 datasources Signed-off-by: Paul Sebastian <[email protected]> * fix linting Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]> (cherry picked from commit a0e7e36) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Mar 20, 2024
* add callout for s3 datasources * fix linting --------- (cherry picked from commit a0e7e36) Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…arch-project#1583) * add callout for s3 datasources * fix linting --------- (cherry picked from commit a0e7e36) Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 21457e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
s3 PPL view:
s3 SQL view:
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.