Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Implement results from no timestamp in Explorer #1573

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 73899a2 from #1554.

* history location state retrieval

Signed-off-by: Paul Sebastian <[email protected]>

* small changes to see results from no timestamp

Signed-off-by: Paul Sebastian <[email protected]>

* remove time field if there is no default timestamp

Signed-off-by: Paul Sebastian <[email protected]>

* explorer events ui update

Signed-off-by: Paul Sebastian <[email protected]>

* changes to disable timepicker

Signed-off-by: Paul Sebastian <[email protected]>

* modify timepicker logic to disappear instead of disable

Signed-off-by: Paul Sebastian <[email protected]>

* allow for visualizations without timestamps

Signed-off-by: Paul Sebastian <[email protected]>

* allow for saved queries to load with no timestamp

Signed-off-by: Paul Sebastian <[email protected]>

* fix linting complaints

Signed-off-by: Paul Sebastian <[email protected]>

* change naming convention

Signed-off-by: Paul Sebastian <[email protected]>

* add new no timestamp jest test

Signed-off-by: Paul Sebastian <[email protected]>

* stop app analytics from crashing

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit 73899a2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mengweieric mengweieric added the enhancement New feature or request label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.15%. Comparing base (cb78382) to head (cb78382).
Report is 1 commits behind head on 2.x.

❗ Current head cb78382 differs from pull request most recent head 2e5ea20. Consider uploading reports for the commit 2e5ea20 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #1573   +/-   ##
=======================================
  Coverage   58.15%   58.15%           
=======================================
  Files         365      365           
  Lines       13549    13549           
  Branches     3562     3562           
=======================================
  Hits         7880     7880           
  Misses       5605     5605           
  Partials       64       64           
Flag Coverage Δ
dashboards-observability 58.15% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mengweieric mengweieric merged commit 21b2acd into 2.x Mar 20, 2024
17 of 32 checks passed
@github-actions github-actions bot deleted the backport/backport-1554-to-2.x branch March 20, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants