Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Data sources bug fixes and UI improvements #1566

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 31d506a from #1565.

* more bug fixes and UI changes

Signed-off-by: Sean Li <[email protected]>

* adding failure states, improving refresh accelerations

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit 31d506a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 58.15%. Comparing base (668a968) to head (83c119e).

Files Patch % Lines
...nage/associated_objects/associated_objects_tab.tsx 73.07% 7 Missing ⚠️
...iated_objects/modules/associated_objects_table.tsx 0.00% 2 Missing ⚠️
...omponents/manage/manage_data_connections_table.tsx 33.33% 2 Missing ⚠️
.../manage/accelerations/utils/acceleration_utils.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1566      +/-   ##
==========================================
+ Coverage   58.10%   58.15%   +0.04%     
==========================================
  Files         363      364       +1     
  Lines       13427    13452      +25     
  Branches     3509     3521      +12     
==========================================
+ Hits         7802     7823      +21     
- Misses       5564     5568       +4     
  Partials       61       61              
Flag Coverage Δ
dashboards-observability 58.15% <69.23%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sejli sejli added the enhancement New feature or request label Mar 19, 2024
@ps48 ps48 merged commit a707810 into 2.x Mar 19, 2024
23 of 34 checks passed
@github-actions github-actions bot deleted the backport/backport-1565-to-2.x branch March 19, 2024 20:04
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…pensearch-project#1566)

* more bug fixes and UI changes

* adding failure states, improving refresh accelerations

---------

(cherry picked from commit 31d506a)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit a707810)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants