Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed small bugs in explorer #1559

Merged

Conversation

paulstn
Copy link
Collaborator

@paulstn paulstn commented Mar 18, 2024

Description

  • For s3 data sources, disabled sorting
  • Disabled autocomplete for s3 ppl
  • For s3, implemented basic working pagination
  • In default data sources: Explorer data grid fix flyout after sort correspond to correct row
  • Fix/reenable surrounding events
  • Create ability for surrounding events to work on s3

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

paulstn added 5 commits March 18, 2024 00:23
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
@paulstn paulstn added enhancement New feature or request backport 2.x labels Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 57.84%. Comparing base (26e8610) to head (1361aef).
Report is 3 commits behind head on main.

Files Patch % Lines
...vent_analytics/explorer/events_views/data_grid.tsx 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1559      +/-   ##
==========================================
+ Coverage   57.79%   57.84%   +0.05%     
==========================================
  Files         364      366       +2     
  Lines       13414    13644     +230     
  Branches     3479     3557      +78     
==========================================
+ Hits         7752     7892     +140     
- Misses       5603     5691      +88     
- Partials       59       61       +2     
Flag Coverage Δ
dashboards-observability 57.84% <16.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Paul Sebastian <[email protected]>
@paulstn paulstn marked this pull request as ready for review March 18, 2024 21:08
@paulstn paulstn marked this pull request as draft March 18, 2024 21:08
@paulstn paulstn marked this pull request as ready for review March 18, 2024 21:09
Signed-off-by: Paul Sebastian <[email protected]>
@ps48
Copy link
Member

ps48 commented Mar 19, 2024

@paulstn Can you please look into build errors?

Signed-off-by: Paul Sebastian <[email protected]>
@paulstn paulstn merged commit 3cec4dc into opensearch-project:main Mar 19, 2024
14 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 19, 2024
* disable ppl direct query autocomplete

Signed-off-by: Paul Sebastian <[email protected]>

* disable sorting for s3

Signed-off-by: Paul Sebastian <[email protected]>

* fix pagination for s3

Signed-off-by: Paul Sebastian <[email protected]>

* fix flyout to use actual row doc

Signed-off-by: Paul Sebastian <[email protected]>

* fix surrounding events

Signed-off-by: Paul Sebastian <[email protected]>

* allow for surrounding fields to work on s3

Signed-off-by: Paul Sebastian <[email protected]>

* fix lint complaint

Signed-off-by: Paul Sebastian <[email protected]>

* const instead of let

Signed-off-by: Paul Sebastian <[email protected]>

* changed naming for isDataSource bool

Signed-off-by: Paul Sebastian <[email protected]>

* update snapshot

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit 3cec4dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric pushed a commit that referenced this pull request Mar 20, 2024
* disable ppl direct query autocomplete



* disable sorting for s3



* fix pagination for s3



* fix flyout to use actual row doc



* fix surrounding events



* allow for surrounding fields to work on s3



* fix lint complaint



* const instead of let



* changed naming for isDataSource bool



* update snapshot



---------


(cherry picked from commit 3cec4dc)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2024
* disable ppl direct query autocomplete

Signed-off-by: Paul Sebastian <[email protected]>

* disable sorting for s3

Signed-off-by: Paul Sebastian <[email protected]>

* fix pagination for s3

Signed-off-by: Paul Sebastian <[email protected]>

* fix flyout to use actual row doc

Signed-off-by: Paul Sebastian <[email protected]>

* fix surrounding events

Signed-off-by: Paul Sebastian <[email protected]>

* allow for surrounding fields to work on s3

Signed-off-by: Paul Sebastian <[email protected]>

* fix lint complaint

Signed-off-by: Paul Sebastian <[email protected]>

* const instead of let

Signed-off-by: Paul Sebastian <[email protected]>

* changed naming for isDataSource bool

Signed-off-by: Paul Sebastian <[email protected]>

* update snapshot

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit 3cec4dc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 added a commit that referenced this pull request Mar 20, 2024
* disable ppl direct query autocomplete



* disable sorting for s3



* fix pagination for s3



* fix flyout to use actual row doc



* fix surrounding events



* allow for surrounding fields to work on s3



* fix lint complaint



* const instead of let



* changed naming for isDataSource bool



* update snapshot



---------


(cherry picked from commit 3cec4dc)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shenoy Pratik <[email protected]>
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…) (opensearch-project#1559)

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit c10031f956ebb05d2f11424e7ddf1552d7a5cb0d)

Co-authored-by: Craig Perkins <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…oject#1580)

* disable ppl direct query autocomplete

* disable sorting for s3

* fix pagination for s3

* fix flyout to use actual row doc

* fix surrounding events

* allow for surrounding fields to work on s3

* fix lint complaint

* const instead of let

* changed naming for isDataSource bool

* update snapshot

---------

(cherry picked from commit 3cec4dc)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 75e91db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants