Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Implement redirection to explorer within data sources #1553

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2a575ed from #1548.

* history location state retrieval

Signed-off-by: Paul Sebastian <[email protected]>

* populate fields as required

Signed-off-by: Paul Sebastian <[email protected]>

* every single change made in datasources

Signed-off-by: Paul Sebastian <[email protected]>

* remove unused method

Signed-off-by: Paul Sebastian <[email protected]>

* remove console log

Signed-off-by: Paul Sebastian <[email protected]>

* use enum for s3 glue

Signed-off-by: Paul Sebastian <[email protected]>

* properly redirect for skipping indices

Signed-off-by: Paul Sebastian <[email protected]>

* fix linting complaints

Signed-off-by: Paul Sebastian <[email protected]>

* updated snapshot

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit 2a575ed)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 28.20513% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 58.07%. Comparing base (d563366) to head (819b842).

Files Patch % Lines
...iated_objects/modules/associated_objects_table.tsx 36.36% 7 Missing ⚠️
...ted_objects/utils/associated_objects_tab_utils.tsx 33.33% 6 Missing ⚠️
.../manage/accelerations/utils/acceleration_utils.tsx 16.66% 5 Missing ⚠️
...ated_objects/associated_objects_details_flyout.tsx 33.33% 4 Missing ⚠️
...nage/accelerations/acceleration_details_flyout.tsx 25.00% 3 Missing ⚠️
...onents/manage/accelerations/acceleration_table.tsx 0.00% 2 Missing ⚠️
.../datasources/components/manage/data_connection.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1553      +/-   ##
==========================================
- Coverage   58.16%   58.07%   -0.09%     
==========================================
  Files         362      362              
  Lines       13176    13205      +29     
  Branches     3438     3445       +7     
==========================================
+ Hits         7664     7669       +5     
- Misses       5453     5477      +24     
  Partials       59       59              
Flag Coverage Δ
dashboards-observability 58.07% <28.20%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paulstn paulstn merged commit a242c78 into 2.x Mar 18, 2024
19 of 32 checks passed
@github-actions github-actions bot deleted the backport/backport-1548-to-2.x branch March 18, 2024 18:41
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…ject#1548) (opensearch-project#1553)

* history location state retrieval

* populate fields as required

* every single change made in datasources

* remove unused method

* remove console log

* use enum for s3 glue

* properly redirect for skipping indices

* fix linting complaints

* updated snapshot

---------

(cherry picked from commit 2a575ed)

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit a242c78)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants