-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data Sources component Improvements and bug fixes #1551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sejli
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
March 17, 2024 09:35
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1551 +/- ##
==========================================
+ Coverage 57.77% 57.79% +0.01%
==========================================
Files 364 364
Lines 13392 13414 +22
Branches 3479 3479
==========================================
+ Hits 7737 7752 +15
- Misses 5596 5603 +7
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
ps48
changed the title
Data Sources Improvements
Data Sources component Improvements and bug fixes
Mar 18, 2024
ps48
reviewed
Mar 18, 2024
...onents/datasources/components/manage/associated_objects/modules/associated_objects_table.tsx
Outdated
Show resolved
Hide resolved
ps48
reviewed
Mar 18, 2024
...ents/datasources/components/manage/accelerations/flyout_modules/accelerations_schema_tab.tsx
Outdated
Show resolved
Hide resolved
ps48
approved these changes
Mar 18, 2024
Signed-off-by: Sean Li <[email protected]>
paulstn
approved these changes
Mar 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
* linking create accelerations flyouts, loading columns Signed-off-by: Sean Li <[email protected]> * rebasing with main, updating types, and fixing refresh accelerations Signed-off-by: Sean Li <[email protected]> * removing comments and console.logs Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit 26e8610) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn
pushed a commit
that referenced
this pull request
Mar 18, 2024
* linking create accelerations flyouts, loading columns * rebasing with main, updating types, and fixing refresh accelerations * removing comments and console.logs --------- (cherry picked from commit 26e8610) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…#1551) (opensearch-project#1557) * linking create accelerations flyouts, loading columns * rebasing with main, updating types, and fixing refresh accelerations * removing comments and console.logs --------- (cherry picked from commit 26e8610) Signed-off-by: Sean Li <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit d960b56)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create Acceleration
flyout to:Create Acceleration
buttonCreate Acceleration
button in associated object detail flyout when there are no accelerationsIssues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.