Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Sources component Improvements and bug fixes #1551

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

sejli
Copy link
Member

@sejli sejli commented Mar 17, 2024

Description

  • Links Create Acceleration flyout to:
    1. Accelerations tab Create Acceleration button
    2. Lightning bolt icon in associated objects table
    3. Lightning bolt icon in associated object detail flyout
    4. Create Acceleration button in associated object detail flyout when there are no accelerations
  • Add loading to cache for table columns
  • Display associated accelerations in associated object table
  • Miscellaneous string and typing updates

image
image
image
image

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 58.00000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 57.79%. Comparing base (2a575ed) to head (c23986e).

Files Patch % Lines
...iated_objects/modules/associated_objects_table.tsx 23.52% 13 Missing ⚠️
...ated_objects/associated_objects_details_flyout.tsx 77.27% 5 Missing ⚠️
...onents/manage/accelerations/acceleration_table.tsx 50.00% 2 Missing ⚠️
...nage/associated_objects/associated_objects_tab.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1551      +/-   ##
==========================================
+ Coverage   57.77%   57.79%   +0.01%     
==========================================
  Files         364      364              
  Lines       13392    13414      +22     
  Branches     3479     3479              
==========================================
+ Hits         7737     7752      +15     
- Misses       5596     5603       +7     
  Partials       59       59              
Flag Coverage Δ
dashboards-observability 57.79% <58.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 changed the title Data Sources Improvements Data Sources component Improvements and bug fixes Mar 18, 2024
@paulstn paulstn merged commit 26e8610 into opensearch-project:main Mar 18, 2024
14 of 20 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 18, 2024
* linking create accelerations flyouts, loading columns

Signed-off-by: Sean Li <[email protected]>

* rebasing with main, updating types, and fixing refresh accelerations

Signed-off-by: Sean Li <[email protected]>

* removing comments and console.logs

Signed-off-by: Sean Li <[email protected]>

---------

Signed-off-by: Sean Li <[email protected]>
(cherry picked from commit 26e8610)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
paulstn pushed a commit that referenced this pull request Mar 18, 2024
* linking create accelerations flyouts, loading columns



* rebasing with main, updating types, and fixing refresh accelerations



* removing comments and console.logs



---------


(cherry picked from commit 26e8610)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
…#1551) (opensearch-project#1557)

* linking create accelerations flyouts, loading columns

* rebasing with main, updating types, and fixing refresh accelerations

* removing comments and console.logs

---------

(cherry picked from commit 26e8610)

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit d960b56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants