Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Update UI styles for query assist #1538

Merged
merged 1 commit into from
Mar 15, 2024
Merged

[Backport 2.x] Update UI styles for query assist #1538

merged 1 commit into from
Mar 15, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9a4e532 from #1523.

@github-actions
Update UI styles for query assist (#1523)
f90708e 
* update ui for query assist

Signed-off-by: Joshua Li <[email protected]>

* mock prohibited query when generating ppl

Signed-off-by: Joshua Li <[email protected]>

* update tests

Signed-off-by: Joshua Li <[email protected]>

* move guardrails check to server side

Signed-off-by: Joshua Li <[email protected]>

* focus input when selecting from suggestion

Signed-off-by: Joshua Li <[email protected]>

* update styles of run buttons

Signed-off-by: Joshua Li <[email protected]>

* hide patterns table by default

Signed-off-by: Joshua Li <[email protected]>

* show loading state for ppl generation

Signed-off-by: Joshua Li <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 9a4e532)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.54545% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 57.21%. Comparing base (2d18a4f) to head (f90708e).

Files Patch % Lines
...ts/event_analytics/explorer/query_assist/input.tsx 56.06% 27 Missing and 2 partials ⚠️
public/components/common/search/query_area.tsx 0.00% 8 Missing ⚠️
...components/event_analytics/explorer/no_results.tsx 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #1538      +/-   ##
==========================================
- Coverage   57.23%   57.21%   -0.02%     
==========================================
  Files         346      346              
  Lines       12479    12522      +43     
  Branches     3169     3248      +79     
==========================================
+ Hits         7142     7165      +23     
- Misses       5284     5301      +17     
- Partials       53       56       +3
Flag Coverage Δ
dashboards-observability 57.21% <54.54%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48 ps48 merged commit 0d770f7 into 2.x Mar 15, 2024
19 of 32 checks passed
@github-actions github-actions bot deleted the backport/backport-1523-to-2.x branch March 15, 2024 16:25
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
@opensearch-trigger-bot @AMoo-Miki @stephen-crawford
[Backport 2.x] Make the steps diagram honor the theme (opensearch-pro…
e10924a 
…ject#1550)

* Make the steps diagram honor the theme (opensearch-project#1538)

Signed-off-by: Miki <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Ryan Liang <[email protected]>
(cherry picked from commit 20ba268e85b6d518a51d587a97b034f924c399f7)

* Update jwt_auth.test.ts

Extend timeout for 2.x line

Signed-off-by: Stephen Crawford <[email protected]>

---------

Signed-off-by: Stephen Crawford <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
@opensearch-trigger-bot
Update UI styles for query assist (opensearch-project#1523) (opensear…
6a19606 
…ch-project#1538)

* update ui for query assist

* mock prohibited query when generating ppl

* update tests

* move guardrails check to server side

* focus input when selecting from suggestion

* update styles of run buttons

* hide patterns table by default

* show loading state for ppl generation

---------

(cherry picked from commit 9a4e532)

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 0d770f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps48 ps48 ps48 approved these changes

@anirudha anirudha anirudha approved these changes

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsimanohar vamsimanohar Awaiting requested review from vamsimanohar

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anirudha @ps48