Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Change class name to decouple styling from discover #1426

Merged
merged 1 commit into from
Feb 9, 2024
Merged

[Backport 2.x] Change class name to decouple styling from discover #1426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions public/components/event_analytics/explorer/explorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
selectVisualizationConfig,
} from '../redux/slices/viualization_config_slice';
import { getDefaultVisConfig } from '../utils';
import { formatError, getContentTabTitle, getDateRange } from '../utils/utils';
import { formatError, getContentTabTitle } from '../utils/utils';
import { DataSourceSelection } from './datasources/datasources_selection';
import { DirectQueryRunning } from './direct_query_running';
import { DataGrid } from './events_views/data_grid';
Expand Down Expand Up @@ -204,7 +204,7 @@
return explorerSearchMeta.datasources?.[0]?.type
? dataSourcePluggables[explorerSearchMeta?.datasources[0]?.type]
: dataSourcePluggables.DEFAULT_INDEX_PATTERNS;
}, [explorerSearchMeta.datasources]);

Check warning on line 207 in public/components/event_analytics/explorer/explorer.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useMemo has a missing dependency: 'dataSourcePluggables'. Either include it or remove the dependency array
const { ui } =
currentPluggable?.getComponentSetForVariation(
'languages',
Expand Down Expand Up @@ -288,10 +288,10 @@
setRefresh({});
});
}
}, []);

Check warning on line 291 in public/components/event_analytics/explorer/explorer.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useEffect has a missing dependency: 'http'. Either include it or remove the dependency array

const getErrorHandler = (title: string) => {
return (error: any) => {

Check warning on line 294 in public/components/event_analytics/explorer/explorer.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Unexpected any. Specify a different type
if (coreRefs.summarizeEnabled) return;
const formattedError = formatError(error.name, error.message, error.body.message);
notifications.toasts.addError(formattedError, {
Expand Down Expand Up @@ -406,7 +406,7 @@
callbackInApp(() => prepareAvailability());
}
}
}, [appBasedRef.current]);

Check warning on line 409 in public/components/event_analytics/explorer/explorer.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useEffect has missing dependencies: 'callback', 'callbackInApp', and 'prepareAvailability'. Either include them or remove the dependency array. Mutable values like 'appBasedRef.current' aren't valid dependencies because mutating them doesn't re-render the component

useEffect(() => {
if (
Expand All @@ -415,14 +415,14 @@
) {
setSelectedContentTab(TAB_CHART_ID);
}
}, []);

Check warning on line 418 in public/components/event_analytics/explorer/explorer.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useEffect has a missing dependency: 'routerContext'. Either include it or remove the dependency array

useEffect(() => {
if (savedObjectId && !isObjectIdUpdatedFromSave.current) {
updateTabData(savedObjectId);
isObjectIdUpdatedFromSave.current = false;
}
}, [savedObjectId]);

Check warning on line 425 in public/components/event_analytics/explorer/explorer.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useEffect has a missing dependency: 'updateTabData'. Either include it or remove the dependency array

const handleTimePickerChange = async (timeRange: string[]) => {
if (appLogEvents) {
Expand Down Expand Up @@ -496,7 +496,7 @@
return hits;
}
return 0;
}, [countDistribution?.data]);

Check warning on line 499 in public/components/event_analytics/explorer/explorer.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useMemo has missing dependencies: 'isLiveTailOn' and 'liveHits'. Either include them or remove the dependency array

const mainContent = useMemo(() => {
return (
Expand Down Expand Up @@ -627,7 +627,7 @@
)}
</div>
);
}, [

Check warning on line 630 in public/components/event_analytics/explorer/explorer.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useMemo has missing dependencies: 'appLogEvents', 'dispatch', 'endTime', 'getCountVisualizations', 'getErrorHandler', 'getPatterns', 'handleTimeRangePickerRefresh', 'http', 'isDefaultDataSourceType', 'liveTimestamp', 'pplService', 'requestParams', 'startTime', 'tabId', 'timeIntervalOptions', and 'totalHits'. Either include them or remove the dependency array. Mutable values like 'isLiveTailOnRef.current' aren't valid dependencies because mutating them doesn't re-render the component
isPanelTextFieldInvalid,
explorerData,
explorerFields,
Expand Down Expand Up @@ -658,7 +658,7 @@
appData: { fromApp: appLogEvents },
explorer: { explorerData, explorerFields, query, http, pplService },
});
}, [curVisId, explorerVisualizations, explorerFields, query, userVizConfigs]);

Check warning on line 661 in public/components/event_analytics/explorer/explorer.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useMemo has missing dependencies: 'appLogEvents', 'explorerData', 'http', 'pplService', and 'visualizationSettings'. Either include them or remove the dependency array

const callbackForConfig = (childFunc: () => void) => {
if (childFunc && triggerAvailability) {
Expand Down Expand Up @@ -688,7 +688,7 @@
}
/>
);
}, [

Check warning on line 691 in public/components/event_analytics/explorer/explorer.tsx

View workflow job for this annotation

GitHub Actions / Lint 

React Hook useMemo has missing dependencies: 'appLogEvents', 'callbackForConfig', 'handleOverrideTimestamp', 'isDefaultDataSourceType', and 'queryManager'. Either include them or remove the dependency array
query,
curVisId,
explorerFields,
Expand Down Expand Up @@ -942,7 +942,7 @@
}}
>
<EuiPage className="deLayout" paddingSize="none">
<EuiPageSideBar className="deSidebar" sticky>
<EuiPageSideBar className="explorerSidebar" sticky>
<EuiSplitPanel.Outer className="eui-yScroll" hasBorder={true} borderRadius="none">
{!appLogEvents && (
<EuiSplitPanel.Inner paddingSize="s" color="subdued" grow={false}>
Expand Down
2 changes: 1 addition & 1 deletion public/components/event_analytics/explorer/sidebar/sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@
padding-left: 8px;
}

.deSidebar {
.explorerSidebar {
height: calc(100vh - 98px);
max-width: 462px;
min-width: 400px;
Expand Down
Loading