-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Improving Jest Test Coverage for Observability Dashboards and Fixing Cypress Tests #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Sean Li <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
+ Coverage 53.95% 55.84% +1.88%
==========================================
Files 317 320 +3
Lines 11360 11703 +343
Branches 3026 3099 +73
==========================================
+ Hits 6129 6535 +406
+ Misses 5182 5117 -65
- Partials 49 51 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sejli
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
February 5, 2024 21:44
Swiddis
approved these changes
Feb 5, 2024
sumukhswamy
approved these changes
Feb 6, 2024
ps48
approved these changes
Feb 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
…ds and Fixing Cypress Tests (#1409) * improving test coverage on panels and fixing flaky cypress tests Signed-off-by: Sean Li <[email protected]> * updating snapshot Signed-off-by: Sean Li <[email protected]> * mocking time so snapshots are consistent Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit 1211e83) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/dashboards-observability
that referenced
this pull request
Feb 14, 2024
…ds and Fixing Cypress Tests (opensearch-project#1409) * improving test coverage on panels and fixing flaky cypress tests Signed-off-by: Sean Li <[email protected]> * updating snapshot Signed-off-by: Sean Li <[email protected]> * mocking time so snapshots are consistent Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit 1211e83) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 3b179c5)
sejli
added a commit
to sejli/dashboards-observability
that referenced
this pull request
Feb 14, 2024
…ds and Fixing Cypress Tests (opensearch-project#1409) * improving test coverage on panels and fixing flaky cypress tests Signed-off-by: Sean Li <[email protected]> * updating snapshot Signed-off-by: Sean Li <[email protected]> * mocking time so snapshots are consistent Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit 1211e83)
6 tasks
paulstn
pushed a commit
that referenced
this pull request
Feb 14, 2024
* [MAINTENANCE] Improving Jest Test Coverage for Observability Dashboards and Fixing Cypress Tests (#1409) * improving test coverage on panels and fixing flaky cypress tests Signed-off-by: Sean Li <[email protected]> * updating snapshot Signed-off-by: Sean Li <[email protected]> * mocking time so snapshots are consistent Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit 1211e83) * cherry picking 3b179c5 and removing fetchAggregatedBins() test Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…es (opensearch-project#1441) * [MAINTENANCE] Improving Jest Test Coverage for Observability Dashboards and Fixing Cypress Tests (opensearch-project#1409) * improving test coverage on panels and fixing flaky cypress tests Signed-off-by: Sean Li <[email protected]> * updating snapshot Signed-off-by: Sean Li <[email protected]> * mocking time so snapshots are consistent Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit 1211e83) * cherry picking 3b179c5 and removing fetchAggregatedBins() test Signed-off-by: Sean Li <[email protected]> --------- Signed-off-by: Sean Li <[email protected]> (cherry picked from commit 8b7966b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reopening to trigger code coverage bot
custom_panels
directoryIssues Resolved
#201 #1278
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.