Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Improving Jest Test Coverage for Observability Dashboards and Fixing Cypress Tests #1408

Closed
wants to merge 3 commits into from
Closed

[MAINTENANCE] Improving Jest Test Coverage for Observability Dashboards and Fixing Cypress Tests #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33ba1d0
updating panels tests and fixing flaky ones
sejli Feb 3, 2024
fc96649
improving test coverage on panels
sejli Feb 3, 2024
d7e4c8c
Merge branch 'main' into panels-test-update
sejli Feb 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions .cypress/integration/panels_test/panels.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
TEST_PANEL,
} from '../../utils/panel_constants';

describe('Panels testing with Sample Data', () => {
describe('Panels testing with Sample Data', { defaultCommandTimeout: 10000 }, () => {
suppressResizeObserverIssue(); //needs to be in file once

before(() => {
Expand All @@ -43,19 +43,18 @@ describe('Panels testing with Sample Data', () => {
});

it('Create first visualization in event analytics', () => {
cy.get('[data-test-subj="eventHomeAction__explorer"]').click();
cy.get('[id^=autocomplete-textarea]').focus().type(PPL_VISUALIZATIONS[0], {
delay: 50,
});
cy.get('.euiButton__text').contains('Refresh').trigger('mouseover').click();
cy.wait(delay); //occationaly refresh wont work without this
cy.get('.euiButton__text').contains('Run').trigger('mouseover').click();
cy.get('button[id="main-content-vis"]')
.contains('Visualizations')
.trigger('mouseover', { force: true })
.click({ force: true });
cy.get('[data-test-subj="eventExplorer__saveManagementPopover"]')
.trigger('mouseover')
.click({ force: true });
cy.wait(delay * 5); //Wont save as correct name without wait
cy.get('[data-test-subj="eventExplorer__querySaveName"]')
.focus()
.type(PPL_VISUALIZATIONS_NAMES[0]);
Expand All @@ -65,16 +64,21 @@ describe('Panels testing with Sample Data', () => {
});

it('Create second visualization in event analytics', () => {
cy.get('[id^=autocomplete-textarea]').focus().type(PPL_VISUALIZATIONS[1]);
cy.get('.euiButton__text').contains('Refresh').trigger('mouseover').click();
cy.get('[data-test-subj="eventHomeAction__explorer"]').click();
// Workaround until issue #1403 is fixed
// Should be the following commented lines
// cy.get('[id^=autocomplete-textarea]').focus().type(PPL_VISUALIZATIONS[1], {
// delay: 50,
// });
cy.get('[id^=autocomplete-textarea]').focus().invoke('val', PPL_VISUALIZATIONS[1]).trigger('input').trigger('change');
cy.get('.euiButton__text').contains('Run').trigger('mouseover').click();
cy.get('button[id="main-content-vis"]')
.contains('Visualizations')
.trigger('mouseover')
.click({ force: true });
cy.get('[data-test-subj="eventExplorer__saveManagementPopover"]')
.trigger('mouseover')
.click();
cy.wait(delay * 5); //Wont save as correct name without wait
cy.get('[data-test-subj="eventExplorer__querySaveName"]')
.focus()
.type(PPL_VISUALIZATIONS_NAMES[1]);
Expand Down Expand Up @@ -151,7 +155,6 @@ describe('Panels testing with Sample Data', () => {
it('Searches panels', () => {
createLegacyPanel('Legacy Named');
createSavedObjectPanel('Saved Object');
cy.wait(delay); //Needed so the panel appears on the dashboard page
cy.reload();
cy.get('input[data-test-subj="operationalPanelSearchBar"]')
.focus()
Expand Down Expand Up @@ -306,15 +309,17 @@ describe('Panels testing with Sample Data', () => {
cy.get('h1[data-test-subj="panelNameHeader"]').contains('Renamed Panel').should('exist');
});

it('Change date filter of the panel', () => {
cy.get('.euiButtonEmpty[data-test-subj="superDatePickerToggleQuickMenuButton"]').click({
// Skipping for now as it's flaky (failed on 34th run)
it.skip('Change date filter of the panel', () => {
cy.intercept('**').as('putRequest');
cy.get('[data-test-subj="superDatePickerToggleQuickMenuButton"]').click({
force: true,
});
cy.wait(delay); //flyout won't open sometimes without
cy.wait('@putRequest');
cy.get('button[data-test-subj="superDatePickerCommonlyUsed_This_year"]').click({
force: true,
});
cy.get('button[data-test-subj="superDatePickerShowDatesButton"]')
cy.get('[data-test-subj="superDatePickerShowDatesButton"]')
.contains('This year')
.should('exist');
});
Expand All @@ -329,7 +334,6 @@ describe('Panels testing with Sample Data', () => {
cy.get('button[data-test-subj="selectExistingVizContextMenuItem"]').click();
cy.get('select').select(PPL_VISUALIZATIONS_NAMES[0]);
cy.get('button[aria-label="refreshPreview"]').trigger('mouseover').click();
cy.get('.plot-container').should('exist');
cy.get('button[data-test-subj="addFlyoutButton"]').click({ force: true });
cy.get('.euiToastHeader__title').contains('successfully').should('exist');
});
Expand All @@ -344,7 +348,6 @@ describe('Panels testing with Sample Data', () => {
cy.get('button[data-test-subj="selectExistingVizContextMenuItem"]').click();
cy.get('select').select(PPL_VISUALIZATIONS_NAMES[1]);
cy.get('button[aria-label="refreshPreview"]').trigger('mouseover').click();
cy.get('.plot-container').should('exist');
cy.get('button[data-test-subj="addFlyoutButton"]').click({ force: true });
cy.get('.euiToastHeader__title').contains('successfully').should('exist');
});
Expand Down Expand Up @@ -380,7 +383,6 @@ describe('Panels testing with Sample Data', () => {
cy.get('[data-test-subj="searchAutocompleteTextArea"]')
.trigger('mouseover')
.click({ force: true })
.wait(delay * 5)
.focus()
.type(PPL_FILTER);
cy.get('button[data-test-subj="superDatePickerApplyTimeButton"]').click({ force: true });
Expand Down Expand Up @@ -553,9 +555,8 @@ describe('Panels testing with Sample Data', () => {
cy.get('button[data-test-subj="createNewVizContextMenuItem"]').click();

cy.url().should('match', new RegExp('(.*)#/explorer'));
cy.get('a[data-test-subj="eventExplorer__addNewTab"]').click({ force: true });
cy.get('[id^=autocomplete-textarea]').focus().type(PPL_VISUALIZATIONS[0]);
cy.get('button[data-test-subj="superDatePickerApplyTimeButton"]').click({ force: true });
cy.get('.euiButton__text').contains('Run').trigger('mouseover').click();

cy.get('button[id="main-content-vis"]')
.contains('Visualizations')
Expand Down
Loading
Loading