-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable data grid in Chatbot #1341
feat: enable data grid in Chatbot #1341
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1341 +/- ##
==========================================
- Coverage 53.72% 51.47% -2.25%
==========================================
Files 314 305 -9
Lines 11267 10628 -639
Branches 2941 2792 -149
==========================================
- Hits 6053 5471 -582
+ Misses 5166 5111 -55
+ Partials 48 46 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
public/components/event_analytics/explorer/events_views/data_grid.tsx
Outdated
Show resolved
Hide resolved
|
||
export const registerAsssitantDependencies = (setup?: AssistantSetup) => { | ||
if (!setup) return; | ||
|
||
setup.registerContentRenderer('ppl_visualization', (content) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need ppl based visualizations in chat anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, only data grid is needed.
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Co-authored-by: Joshua Li <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
190907c
to
68ae592
Compare
@joshuali925 Could we have one more approval to get this PR merged? The registerContentRenderer method has been changed to registerMessageRenderer and we need this PR to get merged. |
Signed-off-by: SuZhou-Joe <[email protected]>
@YANG-DB @joshuali925 Could you please help to merge this PR? |
@joshuali925 @joshuali925 , could you please add |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1341-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 745b4c2643543e991157effc12390c16a128cf94
# Push it to GitHub
git push --set-upstream origin backport/backport-1341-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
sure #1374 |
* feat: enable data grid in Chatbot Signed-off-by: SuZhou-Joe <[email protected]> * feat: update payload Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: Optimize code Co-authored-by: Joshua Li <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> * feat: change to MessageRenderer Signed-off-by: SuZhou-Joe <[email protected]> * feat: change to fullWidth Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1341-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 745b4c2643543e991157effc12390c16a128cf94
# Push it to GitHub
git push --set-upstream origin backport/backport-1341-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
* feat: enable data grid in Chatbot Signed-off-by: SuZhou-Joe <[email protected]> * feat: update payload Signed-off-by: SuZhou-Joe <[email protected]> * feat: add unit test Signed-off-by: SuZhou-Joe <[email protected]> * feat: Optimize code Co-authored-by: Joshua Li <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> * feat: optimize code Signed-off-by: SuZhou-Joe <[email protected]> * feat: change to MessageRenderer Signed-off-by: SuZhou-Joe <[email protected]> * feat: change to fullWidth Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> (cherry picked from commit 745b4c2)
@joshuali925 @YANG-DB , as backport failed, I create backport PR manually here. #1383. Please help to approve. BTW, a minor change(1 line change) in parser, could you please help to review? |
Signed-off-by: SuZhou-Joe <[email protected]>
…t#1333) (opensearch-project#1341) We've noticed there are some permissions in OpenSearch that are not included in the UX dropdown of the security-dashboards-plugin Signed-off-by: Peter Nied <[email protected]> Co-authored-by: Craig Perkins <[email protected]> (cherry picked from commit e5c058804b5983ea273299fffec638c590e02624)
…1341) (opensearch-project#1383) Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit b3430d1)
Description
Issues Resolved
#1343
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.