Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshot tests using enzyme json #1308

Closed
wants to merge 2 commits into from

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Dec 19, 2023

Description

Update snapshot tests using enzyme json. This PR will help inline our test snapshots between main and 2.x.

Updating tests from:

expect(wrapper).toMatchSnapshot();

To:

expect(
  toJson(wrapper, {
    mode: 'deep',
  })
).toMatchSnapshot();

Issues Resolved

Short term fix for #1306

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ps48 added 2 commits December 18, 2023 23:40
Signed-off-by: Shenoy Pratik <[email protected]>
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c57327) 56.32% compared to head (64b60da) 56.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1308   +/-   ##
=======================================
  Coverage   56.32%   56.32%           
=======================================
  Files         327      327           
  Lines       11944    11944           
  Branches     2741     2741           
=======================================
  Hits         6728     6728           
  Misses       5171     5171           
  Partials       45       45           
Flag Coverage Δ
dashboards-observability 56.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ps48
Copy link
Member Author

ps48 commented Dec 19, 2023

This PR has to be rebased after #1305 is merged in. Since, the 2.x branch already has the feature in.

@ps48
Copy link
Member Author

ps48 commented Dec 19, 2023

(maintainers) DO NOT MERGE -> working on another parallel fix right now for babel update.

@ps48
Copy link
Member Author

ps48 commented Dec 21, 2023

Cancelling this PR in favor of long term solution: #1319

@ps48 ps48 closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant