-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook jest updates #1307
Notebook jest updates #1307
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
==========================================
+ Coverage 51.31% 52.92% +1.61%
==========================================
Files 303 302 -1
Lines 10586 10587 +1
Branches 2778 2777 -1
==========================================
+ Hits 5432 5603 +171
+ Misses 5108 4939 -169
+ Partials 46 45 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c6a4be2
to
cc09644
Compare
db13083
to
99bdc51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking issues
return this.state.parsedPara | ||
.map((para: ParaType, index: number) => () => reducer(para, index)) | ||
.map((para: ParaType, _index: number) => () => reducer(para, _index)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we update _index to indicate it's unused, while using it in reducer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter is not able to understand that index is used in reducer and leads to no-unused-vars
error. So marked this one as an internal variable.
const { getByText, getByLabelText, queryByText } = renderNoteTable({ notebooks }); | ||
|
||
// Select a notebook | ||
fireEvent.click(getByLabelText('Select this row')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of duplicated navigation logic here based on label text, that seems like something that's likely to break over time. Should there be a helper for this navigation, or a better selector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this one as is for now. I'm updating some of these with cypress.
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
e78034e
to
a817e66
Compare
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
482806e
to
5ad0dbd
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1307-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 de90b01508a39117f6aa9115c073eff8229c0f56
# Push it to GitHub
git push --set-upstream origin backport/backport-1307-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
* fix support for observability visualizations Signed-off-by: Shenoy Pratik <[email protected]> * update note_table tests Signed-off-by: Shenoy Pratik <[email protected]> * notebook.tsx test first update Signed-off-by: Shenoy Pratik <[email protected]> * update paragraph/notebook action tests Signed-off-by: Shenoy Pratik <[email protected]> * lint fixes Signed-off-by: Shenoy Pratik <[email protected]> * updating paragraph components Signed-off-by: Shenoy Pratik <[email protected]> * add test for rendering error in query Signed-off-by: Shenoy Pratik <[email protected]> * snapshot updates and adding missing tests Signed-off-by: Shenoy Pratik <[email protected]> * remove unnecessary jest mock import Signed-off-by: Shenoy Pratik <[email protected]> * history.push jest function added Signed-off-by: Shenoy Pratik <[email protected]> * merge notebooks tests contants file Signed-off-by: Shenoy Pratik <[email protected]> * make tests more atomic Signed-off-by: Shenoy Pratik <[email protected]> * updated snapshot Signed-off-by: Shenoy Pratik <[email protected]> * atomicized code block checks Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit de90b01)
* Notebook jest updates (#1307) * fix support for observability visualizations Signed-off-by: Shenoy Pratik <[email protected]> * update note_table tests Signed-off-by: Shenoy Pratik <[email protected]> * notebook.tsx test first update Signed-off-by: Shenoy Pratik <[email protected]> * update paragraph/notebook action tests Signed-off-by: Shenoy Pratik <[email protected]> * lint fixes Signed-off-by: Shenoy Pratik <[email protected]> * updating paragraph components Signed-off-by: Shenoy Pratik <[email protected]> * add test for rendering error in query Signed-off-by: Shenoy Pratik <[email protected]> * snapshot updates and adding missing tests Signed-off-by: Shenoy Pratik <[email protected]> * remove unnecessary jest mock import Signed-off-by: Shenoy Pratik <[email protected]> * history.push jest function added Signed-off-by: Shenoy Pratik <[email protected]> * merge notebooks tests contants file Signed-off-by: Shenoy Pratik <[email protected]> * make tests more atomic Signed-off-by: Shenoy Pratik <[email protected]> * updated snapshot Signed-off-by: Shenoy Pratik <[email protected]> * atomicized code block checks Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit de90b01) * update para_query_grid Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]>
…earch-project#1346) * Notebook jest updates (opensearch-project#1307) * fix support for observability visualizations Signed-off-by: Shenoy Pratik <[email protected]> * update note_table tests Signed-off-by: Shenoy Pratik <[email protected]> * notebook.tsx test first update Signed-off-by: Shenoy Pratik <[email protected]> * update paragraph/notebook action tests Signed-off-by: Shenoy Pratik <[email protected]> * lint fixes Signed-off-by: Shenoy Pratik <[email protected]> * updating paragraph components Signed-off-by: Shenoy Pratik <[email protected]> * add test for rendering error in query Signed-off-by: Shenoy Pratik <[email protected]> * snapshot updates and adding missing tests Signed-off-by: Shenoy Pratik <[email protected]> * remove unnecessary jest mock import Signed-off-by: Shenoy Pratik <[email protected]> * history.push jest function added Signed-off-by: Shenoy Pratik <[email protected]> * merge notebooks tests contants file Signed-off-by: Shenoy Pratik <[email protected]> * make tests more atomic Signed-off-by: Shenoy Pratik <[email protected]> * updated snapshot Signed-off-by: Shenoy Pratik <[email protected]> * atomicized code block checks Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit de90b01) * update para_query_grid Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 5454b17)
Description
Issues Resolved
#1338
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.