Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Zeppelin code and docs #1296

Merged
merged 6 commits into from
Jan 5, 2024
Merged

Removes Zeppelin code and docs #1296

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2c9e04b
Update admin:admin reference
derek-ho Dec 13, 2023
9a6acb1
Remove zeppelin code and docs
derek-ho Dec 26, 2023
5c927ac
Remove unecessary files
derek-ho Jan 5, 2024
7f6aaa8
Remove unnecessary constant
derek-ho Jan 5, 2024
274182c
Merge branch 'main' of github.com:opensearch-project/dashboards-obser…
derek-ho Jan 5, 2024
d16c1ed
Remove file
derek-ho Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/constants/notebooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

export const NOTEBOOKS_API_PREFIX = '/api/observability/notebooks';
export const NOTEBOOKS_SELECTED_BACKEND: 'ZEPPELIN' | 'DEFAULT' = 'DEFAULT';
export const NOTEBOOKS_SELECTED_BACKEND = 'DEFAULT';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this constant if not used anywhere.

export const NOTEBOOKS_FETCH_SIZE = 1000;
export const CREATE_NOTE_MESSAGE = 'Enter a name to describe the purpose of this notebook.';
export const NOTEBOOKS_DOCUMENTATION_URL =
Expand Down
44 changes: 0 additions & 44 deletions public/components/notebooks/components/helpers/__tests__/zeppelin_parser.test.tsx
View file
Open in desktop

This file was deleted.

8 changes: 1 addition & 7 deletions public/components/notebooks/components/notebook.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ import {
contextMenuViewReports,
generateInContextReport,
} from './helpers/reporting_context_menu_helper';
import { zeppelinParagraphParser } from './helpers/zeppelin_parser';
import { Paragraphs } from './paragraph_components/paragraphs';
const panelStyles: CSS.Properties = {
float: 'left',
Expand Down Expand Up @@ -140,12 +139,7 @@ export class Notebook extends Component<NotebookProps, NotebookState> {
try {
let parsedPara;
// @ts-ignore
if (NOTEBOOKS_SELECTED_BACKEND === 'ZEPPELIN') {
parsedPara = zeppelinParagraphParser(paragraphs);
this.setState({ vizPrefix: '%sh #vizobject:' });
} else {
parsedPara = defaultParagraphParser(paragraphs);
}
parsedPara = defaultParagraphParser(paragraphs);
parsedPara.forEach((para: ParaType) => {
para.isInputExpanded = this.state.selectedViewId === 'input_only';
para.paraRef = React.createRef();
Expand Down
129 changes: 0 additions & 129 deletions public/components/notebooks/docs/dev/Zeppelin_backend_adaptor.md
View file
Open in desktop

This file was deleted.

Binary file removed public/components/notebooks/docs/dev/images/zeppelin_architecture.png
View file
Open in desktop
Binary file not shown.
1 change: 0 additions & 1 deletion .../components/notebooks/docs/example_notebooks/zeppelin/Introduction Notebook-Zeppelin.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion public/components/notebooks/docs/example_notebooks/zeppelin/Log Analysis-Zeppelin.json
View file
Open in desktop

This file was deleted.

Loading
Loading