-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard prod jenkins docker images to github actions #1223
Onboard prod jenkins docker images to github actions #1223
Conversation
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
cd ./OpenSearch-Dashboards/ | ||
su `id -un 1000` -c "source $NVM_DIR/nvm.sh && nvm use && node -v && yarn -v && | ||
cd plugins/dashboards-observability && | ||
yarn osd bootstrap && yarn test --coverage --maxWorkers=100%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need yarn osd bootstrap
again. If this is done already on line 52.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One in OSD folder one in obs folder.
Normally I see doing this in obs folder / plugin folder is enough.
Tho your original code did it in OSD not plugin so it might miss things that is why I add it again, should not harm 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my experience, just the OSD bootstrap has sufficed, not sure I've needed two bootstraps before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If bootstrap in plugin folder then yeah one is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't matter where, it's calling the same osd
script
@@ -68,14 +138,6 @@ jobs: | |||
cd OpenSearch-Dashboards/plugins/dashboards-observability | |||
yarn test --coverage --maxWorkers=100% | |||
|
|||
- name: Upload coverage | |||
if: ${{ matrix.os == 'ubuntu-latest' }} | |||
uses: codecov/codecov-action@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason we're removing codecov? Because it was moved to the linux build
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1223-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e24d6e7541c888e0e5f6463c2195441cd4e31b59
# Push it to GitHub
git push --set-upstream origin backport/backport-1223-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
Will manually backport. |
Manually Backported here: #1225 |
Description
Onboard prod jenkins docker images to github actions
Issues Resolved
#1097
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.