Switch heading types on integrations setup page #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
penghuo,
seankao-az and
anirudha
as code owners
YANG-DB
approved these changes
Oct 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #1136 +/- ##
=======================================
Coverage 44.20% 44.20%
=======================================
Files 327 327
Lines 19487 19487
Branches 4643 4643
=======================================
Hits 8614 8614
Misses 10828 10828
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. |
derek-ho
approved these changes
Oct 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
(cherry picked from commit 4540326) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
(cherry picked from commit 4540326) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
pushed a commit
that referenced
this pull request
Oct 17, 2023
derek-ho
pushed a commit
that referenced
this pull request
Oct 17, 2023
mengweieric
added a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Nov 13, 2023
mengweieric
added a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Nov 13, 2023
…roject#1136) (opensearch-project#1137)" This reverts commit 7196704. Signed-off-by: Eric <[email protected]>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
) (opensearch-project#1138) (cherry picked from commit 4540326) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit a151236)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current integrations setup page has had mismatched headers due to strange behavior of
EuiTitle. We switch it toEuiTextand update the header scales to look correctly matched.Before:
After:
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.