Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Datasource (Hard coded) #1046

Closed

Conversation

derek-ho
Copy link
Collaborator

Description

Adds most of the flow for configure datasource:

  • Card view including opensearch and spark
  • Clicking on spark allows you to configure it
  • Sending one sends off the network request to POST to /_plugins/_datasources

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #1046 (ed8cfc1) into feature/flint-UI (ad153ed) will decrease coverage by 1.55%.
The diff coverage is n/a.

❗ Current head ed8cfc1 differs from pull request most recent head 0b84fab. Consider uploading reports for the commit 0b84fab to get more accurate results

@@                 Coverage Diff                  @@
##           feature/flint-UI    #1046      +/-   ##
====================================================
- Coverage             45.47%   43.92%   -1.55%     
====================================================
  Files                   329      325       -4     
  Lines                 19968    18949    -1019     
  Branches               4863     4598     -265     
====================================================
- Hits                   9080     8323     -757     
+ Misses                10312    10070     -242     
+ Partials                576      556      -20     
Flag Coverage Δ
dashboards-observability 43.92% <ø> (-1.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 42 files with indirect coverage changes

@derek-ho derek-ho deleted the branch opensearch-project:feature/flint-UI September 25, 2023 17:37
@derek-ho derek-ho closed this Sep 25, 2023
pjfitzgibbons pushed a commit that referenced this pull request Oct 5, 2023
…Label (#1046)

* Data Configurations Panel UI implementation

Signed-off-by: harshada.lingayat <[email protected]>

* Data Configurations Panel UI implementation

Signed-off-by: harshada.lingayat <[email protected]>

* Review comments resolved

Signed-off-by: harshada.lingayat <[email protected]>

* Made code compatible with PR changes

Signed-off-by: harshada.lingayat <[email protected]>

* Custom Label two way sync implementation

Signed-off-by: harshada.lingayat <[email protected]>

* Minor fix

Signed-off-by: harshada.lingayat <[email protected]>

* internal review comments resolved

Signed-off-by: harshada.lingayat <[email protected]>

* Review comments resolved

Signed-off-by: harshada.lingayat <[email protected]>

* Comments resolved

Signed-off-by: harshada.lingayat <[email protected]>

* Added tooltip in aggregation

Signed-off-by: harshada.lingayat <[email protected]>

Signed-off-by: harshada.lingayat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant