Update E2E Test Config #1025
Merged
Update E2E Test Config #1025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 43.59% 44.23% +0.63%
==========================================
Files 312 313 +1
Lines 18581 18830 +249
Branches 4479 4606 +127
==========================================
+ Hits 8101 8329 +228
+ Misses 10438 9957 -481
- Partials 42 544 +502
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
force-pushed
the
fix-e2e
branch
4 times, most recently
from
0c28c08 to
25597ea
Compare
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
We have multiple minutes of bootstrapping, and OSD itself waits for OS to start. Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
requested review from
pjfitzgibbons,
ps48,
kavithacm and
derek-ho
as code owners
Swiddis
requested review from
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
penghuo,
seankao-az and
anirudha
as code owners
YANG-DB
approved these changes
Sep 19, 2023
derek-ho
approved these changes
Sep 20, 2023
pjfitzgibbons
pushed a commit
that referenced
this pull request
Sep 26, 2023
* fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <[email protected]> * change to sonnatype Signed-off-by: Derek Ho <[email protected]> * try to figure out where are we Signed-off-by: Derek Ho <[email protected]> * try with file name Signed-off-by: Derek Ho <[email protected]> * cut sleep time Signed-off-by: Derek Ho <[email protected]> * Add a workflow_dispatch event to E2E Signed-off-by: Simeon Widdis <[email protected]> * Attempt to edit workflow pulling Signed-off-by: Simeon Widdis <[email protected]> * Remove commented bash lines Signed-off-by: Simeon Widdis <[email protected]> * Attempt new plugin names Signed-off-by: Simeon Widdis <[email protected]> * Use sonatype artifact links Signed-off-by: Simeon Widdis <[email protected]> * Fix link Signed-off-by: Simeon Widdis <[email protected]> * Rename SQL artifact download Signed-off-by: Simeon Widdis <[email protected]> * Hardcode correct node version Signed-off-by: Simeon Widdis <[email protected]> * Use other action for file download Signed-off-by: Simeon Widdis <[email protected]> * Fix path for install Signed-off-by: Simeon Widdis <[email protected]> * Remove redundant sleep We have multiple minutes of bootstrapping, and OSD itself waits for OS to start. Signed-off-by: Simeon Widdis <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: Simeon Widdis <[email protected]> Co-authored-by: Derek Ho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the E2E workflow to download the correct files, making the nightly test runs at least get to the Cypress step with a correctly running OS instance. Some work may still be needed to actually make the tests run correctly. Shoutout to @derek-ho for figuring out the bulk of the work months before I got to investigating it.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.