Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Notebooks - New into full-page form #9

Closed
pjfitzgibbons opened this issue Nov 23, 2022 · 2 comments · Fixed by #152
Closed

Convert Notebooks - New into full-page form #9

pjfitzgibbons opened this issue Nov 23, 2022 · 2 comments · Fixed by #152
Assignees
@derek-ho
Labels
v2.6.0

Comments

@pjfitzgibbons
Copy link
Contributor

pjfitzgibbons commented Nov 23, 2022 •
edited
Loading

Currently Notebooks raises a UI Dialog to create a new item.

In order to integrate Notebooks with Dashboards List, the New operation must navigate to an addressable URL -> a full-page form.

Will need to copy/re-write from previous PR into this repo : opensearch-project/observability#1308

Image
@derek-ho derek-ho mentioned this issue Dec 5, 2022
Closed
6 tasks
@derek-ho
Copy link
Collaborator

derek-ho commented Dec 5, 2022 •
edited
Loading

Screen.Recording.2022-12-05.at.3.17.24.PM.mov

@derek-ho
Copy link
Collaborator

derek-ho commented Dec 5, 2022

205733672-ac4b66fd-d9ae-4dc0-94a3-6871ee9bb8c8.mov

@anirudha @pjfitzgibbons @kavithacm here is what the new create/rename notebooks flow looks like, kept clone notebooks in a modal for now..

@derek-ho derek-ho transferred this issue from opensearch-project/observability Jan 3, 2023
@pjfitzgibbons pjfitzgibbons mentioned this issue Feb 1, 2023
Merged
7 tasks
@pjfitzgibbons pjfitzgibbons linked a pull request Feb 1, 2023 that will close this issue
Add new page/route for notebooks create and rename #152
Merged
7 tasks
This was referenced Feb 16, 2023
Merged
Closed
derek-ho pushed a commit to derek-ho/dashboards-observability that referenced this issue Jun 29, 2023
@Swiddis
Merge pull request opensearch-project#9 from derek-ho/toast
251ace2 
hook up toast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derek-ho derek-ho

Labels
v2.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new page/route for notebooks create and rename derek-ho/dashboards-observability
2 participants
@pjfitzgibbons @derek-ho