Merge pull request #588 from mengweieric/feature/prerelease-code-cleanup

(cherry picked from commit a85b716)

public/components/custom_panels/helpers/__tests__/__snapshots__/utils.test.tsx.snap

@@ -409,7 +409,6 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
           "fillopacity": 100,
           "fulllabel": "Vertical bar",
           "groupwidth": 0.7,
-          "icon": [Function],
           "icontype": "visBarVerticalStacked",
           "id": "bar",
           "label": "Vertical bar",
@@ -858,7 +857,6 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
             "fillopacity": 100,
             "fulllabel": "Vertical bar",
             "groupwidth": 0.7,
-            "icon": [Function],
             "icontype": "visBarVerticalStacked",
             "id": "bar",
             "label": "Vertical bar",
@@ -1314,7 +1312,6 @@ exports[`Utils helper functions renders displayVisualization function 1`] = `
               "fillopacity": 100,
               "fulllabel": "Vertical bar",
               "groupwidth": 0.7,
-              "icon": [Function],
               "icontype": "visBarVerticalStacked",
               "id": "bar",
               "label": "Vertical bar",
@@ -2015,7 +2012,6 @@ exports[`Utils helper functions renders displayVisualization function 2`] = `
             ],
           },
           "fulllabel": "Time series",
-          "icon": [Function],
           "icontype": "visLine",
           "id": "line",
           "label": "Time series",
@@ -2532,7 +2528,6 @@ exports[`Utils helper functions renders displayVisualization function 2`] = `
               ],
             },
             "fulllabel": "Time series",
-            "icon": [Function],
             "icontype": "visLine",
             "id": "line",
             "label": "Time series",
@@ -3063,7 +3058,6 @@ exports[`Utils helper functions renders displayVisualization function 2`] = `
                 ],
               },
               "fulllabel": "Time series",
-              "icon": [Function],
               "icontype": "visLine",
               "id": "line",
               "label": "Time series",
@@ -3739,7 +3733,6 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
           "fillopacity": 100,
           "fulllabel": "Horizontal bar",
           "groupwidth": 0.7,
-          "icon": [Function],
           "icontype": "visBarHorizontalStacked",
           "id": "horizontal_bar",
           "label": "Horizontal bar",
@@ -4188,7 +4181,6 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
             "fillopacity": 100,
             "fulllabel": "Horizontal bar",
             "groupwidth": 0.7,
-            "icon": [Function],
             "icontype": "visBarHorizontalStacked",
             "id": "horizontal_bar",
             "label": "Horizontal bar",
@@ -4644,7 +4636,6 @@ exports[`Utils helper functions renders displayVisualization function 3`] = `
               "fillopacity": 100,
               "fulllabel": "Horizontal bar",
               "groupwidth": 0.7,
-              "icon": [Function],
               "icontype": "visBarHorizontalStacked",
               "id": "horizontal_bar",
               "label": "Horizontal bar",

public/components/event_analytics/explorer/visualizations/shared_components/__tests__/__snapshots__/shared_components.test.tsx.snap

@@ -1,95 +1,5 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Shared components Renders empty placeholder component 1`] = `
-<Component
-  icon={[Function]}
->
-  <EuiText
-    className="lnsChart__empty"
-    color="subdued"
-    data-test-subj="vizWorkspace__noData"
-    size="xs"
-    textAlign="center"
-  >
-    <div
-      className="euiText euiText--extraSmall lnsChart__empty"
-      data-test-subj="vizWorkspace__noData"
-    >
-      <EuiTextAlign
-        textAlign="center"
-      >
-        <div
-          className="euiTextAlign euiTextAlign--center"
-        >
-          <EuiTextColor
-            color="subdued"
-            component="div"
-          >
-            <div
-              className="euiTextColor euiTextColor--subdued"
-            >
-              <EuiIcon
-                color="subdued"
-                size="xxl"
-                type={[Function]}
-              >
-                <Component
-                  aria-hidden={true}
-                  className="euiIcon euiIcon--xxLarge euiIcon--subdued"
-                  focusable="false"
-                  role="img"
-                  style={null}
-                >
-                  <svg
-                    aria-hidden={true}
-                    className="euiIcon euiIcon--xxLarge euiIcon--subdued"
-                    fill="none"
-                    focusable="false"
-                    height={22}
-                    role="img"
-                    style={null}
-                    viewBox="0 0 30 22"
-                    width={30}
-                    xmlns="http://www.w3.org/2000/svg"
-                  >
-                    <path
-                      className="lensChartIcon__subdued"
-                      d="M5 7a1 1 0 011 1v13a1 1 0 01-1 1H1a1 1 0 01-1-1V8a1 1 0 011-1h4zm16-7a1 1 0 011 1v20a1 1 0 01-1 1h-4a1 1 0 01-1-1V1a1 1 0 011-1h4z"
-                    />
-                    <path
-                      className="lensChartIcon__accent"
-                      d="M13 11a1 1 0 011 1v9a1 1 0 01-1 1H9a1 1 0 01-1-1v-9a1 1 0 011-1h4zm16-7a1 1 0 011 1v16a1 1 0 01-1 1h-4a1 1 0 01-1-1V5a1 1 0 011-1h4z"
-                    />
-                  </svg>
-                </Component>
-              </EuiIcon>
-              <EuiSpacer
-                size="l"
-              >
-                <div
-                  className="euiSpacer euiSpacer--l"
-                />
-              </EuiSpacer>
-              <p>
-                <FormattedMessage
-                  defaultMessage="No data found"
-                  id="visualization_noData"
-                  values={Object {}}
-                >
-                  <span>
-                    No data found
-                  </span>
-                </FormattedMessage>
-              </p>
-            </div>
-          </EuiTextColor>
-        </div>
-      </EuiTextAlign>
-    </div>
-  </EuiText>
-</Component>
-`;
-
 exports[`Shared components Renders tool bar button component 1`] = `
 <Component
   fontWeight="bold"

public/components/event_analytics/explorer/visualizations/shared_components/__tests__/shared_components.test.tsx

@@ -7,23 +7,11 @@ import { configure, mount } from 'enzyme';
 import Adapter from 'enzyme-adapter-react-16';
 import React from 'react';
 import { waitFor } from '@testing-library/react';
-import { EmptyPlaceholder } from '../empty_placeholder';
-import { LensIconChartBar } from '../../../../../visualizations/assets/chart_bar';
 import { ToolbarButton } from '../toolbar_button';
 
 describe('Shared components', () => {
   configure({ adapter: new Adapter() });
 
-  it('Renders empty placeholder component', async () => {
-    const wrapper = mount(<EmptyPlaceholder icon={LensIconChartBar} />);
-
-    wrapper.update();
-
-    await waitFor(() => {
-      expect(wrapper).toMatchSnapshot();
-    });
-  });
-
   it('Renders tool bar button component', async () => {
     const handleClick = jest.fn();
     const WrappedComponent = () => <div>testing</div>;

public/components/event_analytics/explorer/visualizations/shared_components/plotly_viz_editor/index.tsx

@@ -1 +1,2 @@
 export { PlotlyVizEditor } from './plotly_viz_editor';
+export { PlotlyEditorActionsMenu } from './plotly_actions';

public/components/event_analytics/explorer/visualizations/visualization_specs/default_spec.ts

@@ -1,6 +1,4 @@
 // @ts-ignore
-
-import hjson from 'hjson';
 import defaultLayoutSpec from '!!raw-loader!./default.layout.spec.hjson';
 import defaultDataSpec from '!!raw-loader!./default.data.spec.hjson';