Skip to content

Commit

Permalink
Fix some lint
Browse files Browse the repository at this point in the history
Signed-off-by: Ryan Liang <[email protected]>
  • Loading branch information
RyanL1997 committed Jan 4, 2024
1 parent da08066 commit 1c64ef2
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
16 changes: 11 additions & 5 deletions .cypress/integration/datasources_test/datasources_basic_ui.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ import {

const manageDataSourcesTag = 'button[data-test-subj="manage"]';
const newDataSourcesTag = 'button[data-test-subj="new"]';
const createS3Button = '[data-test-subj="datasource_card_s3glue"]'
const createS3Button = '[data-test-subj="datasource_card_s3glue"]';
const createPrometheusButton = '[data-test-subj="datasource_card_prometheus"]';

const visitDatasourcesHomePage = () => {
cy.visit(FONTEND_BASE_PATH + DATASOURCES_API_PREFIX);
}
};

const visitDatasourcesCreationPage = () => {
cy.visit(FONTEND_BASE_PATH + DATASOURCES_PATH.DATASOURCES_CREATION_BASE);
}
};

describe('Integration tests for datasources plugin', () => {
it('Navigates to datasources plugin and expects the correct header', () => {
Expand Down Expand Up @@ -51,7 +51,10 @@ describe('Integration tests for datasources plugin', () => {
visitDatasourcesCreationPage();

cy.get(createS3Button).should('be.visible').click();
cy.url().should('include', DATASOURCES_PATH.DATASOURCES_CONFIG_BASE + '/AmazonS3AWSGlue')
cy.url().should(
'include',
DATASOURCES_PATH.DATASOURCES_CONFIG_BASE + '/AmazonS3AWSGlue'
);

cy.get('h1.euiTitle.euiTitle--medium')
.should('be.visible')
Expand All @@ -62,7 +65,10 @@ describe('Integration tests for datasources plugin', () => {
visitDatasourcesCreationPage();

cy.get(createPrometheusButton).should('be.visible').click();
cy.url().should('include', DATASOURCES_PATH.DATASOURCES_CONFIG_BASE + '/Prometheus')
cy.url().should(
'include',
DATASOURCES_PATH.DATASOURCES_CONFIG_BASE + '/Prometheus'
);

cy.get('h4.euiTitle.euiTitle--medium')
.should('be.visible')
Expand Down
2 changes: 1 addition & 1 deletion .cypress/utils/constants.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const DATASOURCES_API_PREFIX = '/app/datasources';
export const DATASOURCES_PATH = {
DATASOURCES_CREATION_BASE: `${DATASOURCES_API_PREFIX}#/new`,
DATASOURCES_CONFIG_BASE: `${DATASOURCES_API_PREFIX}#/configure`
}
};

// trace analytics
export const TRACE_ID = '8832ed6abbb2a83516461960c89af49d';
Expand Down

0 comments on commit 1c64ef2

Please sign in to comment.