Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.8] Fix CI on Node.js v18 (#56) #58

Merged

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented May 31, 2023

  • Fix CI on Node.js v18

Signed-off-by: suzhou [email protected]

  • feat: update release notes

Signed-off-by: suzhou [email protected]


Signed-off-by: suzhou [email protected]
(cherry picked from commit 6d576e4)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Fix CI on Node.js v18

Signed-off-by: suzhou <[email protected]>

* feat: update release notes

Signed-off-by: suzhou <[email protected]>

---------

Signed-off-by: suzhou <[email protected]>
(cherry picked from commit 6d576e4)
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #58 (44dbb64) into 2.8 (1af6c92) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.8      #58   +/-   ##
=======================================
  Coverage   86.40%   86.40%           
=======================================
  Files          51       51           
  Lines        1479     1479           
  Branches      352      352           
=======================================
  Hits         1278     1278           
  Misses        198      198           
  Partials        3        3           
Flag Coverage Δ
dashboards-notifications 86.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Hailong-am Hailong-am merged commit d369cfb into opensearch-project:2.8 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants