-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist dataSourceId across applications under new Nav change #244
Persist dataSourceId across applications under new Nav change #244
Conversation
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
UTs passing locally:
|
Signed-off-by: Riya Saxena <[email protected]>
need to check with osd team why installation of notification plugin in osd is failing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
- Coverage 82.79% 82.72% -0.08%
==========================================
Files 55 55
Lines 1686 1702 +16
Branches 455 457 +2
==========================================
+ Hits 1396 1408 +12
- Misses 283 287 +4
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-244-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f209c40d3124fb5a52fde7b081684aec4f7fc76f
# Push it to GitHub
git push --set-upstream origin backport/backport-244-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x Then, create a pull request where the |
…arch-project#244) * Persist dataSourceId across applications under new Nav change Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fix UTs Signed-off-by: Riya Saxena <[email protected]> * moved to constants Signed-off-by: Riya Saxena <[email protected]> * revert changes in snapshot files Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit f209c40)
…249) * Persist dataSourceId across applications under new Nav change Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fix UTs Signed-off-by: Riya Saxena <[email protected]> * moved to constants Signed-off-by: Riya Saxena <[email protected]> * revert changes in snapshot files Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit f209c40) Signed-off-by: Riya <[email protected]>
…249) * Persist dataSourceId across applications under new Nav change Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fix UTs Signed-off-by: Riya Saxena <[email protected]> * moved to constants Signed-off-by: Riya Saxena <[email protected]> * revert changes in snapshot files Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit f209c40) Signed-off-by: Riya <[email protected]> (cherry picked from commit 0bc8724)
…249) (#255) * Persist dataSourceId across applications under new Nav change Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fix UTs Signed-off-by: Riya Saxena <[email protected]> * moved to constants Signed-off-by: Riya Saxena <[email protected]> * revert changes in snapshot files Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit f209c40) Signed-off-by: Riya <[email protected]> (cherry picked from commit 0bc8724) Co-authored-by: Riya <[email protected]>
Description
Issues Resolved
fix-mds.mov
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.