side navigation changes for notifications #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan and
AWSHurneyt
as code owners
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
SuZhou-Joe
reviewed
Jul 19, 2024
public/plugin.ts
Outdated
| if (core.chrome.navGroup.getNavGroupEnabled()) { | ||
|
|
||
| // register applications with category and use case information | ||
| core.chrome.navGroup.addNavLinksToGroup(DEFAULT_NAV_GROUPS.observability, [ |
There was a problem hiding this comment.
Notification features should be only put into settings and setup nav group.
There was a problem hiding this comment.
@amsiglan ^^
Signed-off-by: Riya Saxena <[email protected]>
AWSHurneyt
approved these changes
Jul 19, 2024
amsiglan
reviewed
Jul 19, 2024
public/plugin.ts
Outdated
| }, | ||
| }); | ||
|
|
||
| const navLinks = [ |
There was a problem hiding this comment.
Nit: Shorten this to
const navlinks = ['', '', ''].map(id => ({ id, parent: PLUGIN }))
amsiglan
reviewed
Jul 19, 2024
| id: `email_groups`, | ||
| title: 'Email recepient groups', | ||
| order: 9090, | ||
| workspaceAvailability: WorkspaceAvailability.outsideWorkspace, |
There was a problem hiding this comment.
What is workspaceAvailability? and what are the other options used for? Could this be workspace/no-workspace distinction?
There was a problem hiding this comment.
yes, so plugins under groups of:
settings and setup
Data administration
are supposed not to be accessible inside a workspace, in such case, we added this field to indicate our plugins are only accessible outside the workspace so that users won’t be able to visit the applications inside a workspace.
Signed-off-by: Riya Saxena <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 86.70% 84.83% -1.87%
==========================================
Files 52 54 +2
Lines 1497 1583 +86
Branches 373 414 +41
==========================================
+ Hits 1298 1343 +45
- Misses 196 237 +41
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jul 22, 2024
SuZhou-Joe
reviewed
Jul 22, 2024
Signed-off-by: SuZhou-Joe <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
* side navigation changes for notifications Signed-off-by: Riya Saxena <[email protected]> * fix jest tests Signed-off-by: Riya Saxena <[email protected]> * navLinks changes Signed-off-by: Riya Saxena <[email protected]> * fixed the issues Signed-off-by: Riya Saxena <[email protected]> * fixed the issues Signed-off-by: Riya Saxena <[email protected]> * addressed the comments Signed-off-by: Riya Saxena <[email protected]> * addressed the comments Signed-off-by: Riya Saxena <[email protected]> * Update public/plugin.ts Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 9e6066a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jul 22, 2024
* side navigation changes for notifications * fix jest tests * navLinks changes * fixed the issues * fixed the issues * addressed the comments * addressed the comments * Update public/plugin.ts --------- (cherry picked from commit 9e6066a) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
* side navigation changes for notifications Signed-off-by: Riya Saxena <[email protected]> * fix jest tests Signed-off-by: Riya Saxena <[email protected]> * navLinks changes Signed-off-by: Riya Saxena <[email protected]> * fixed the issues Signed-off-by: Riya Saxena <[email protected]> * fixed the issues Signed-off-by: Riya Saxena <[email protected]> * addressed the comments Signed-off-by: Riya Saxena <[email protected]> * addressed the comments Signed-off-by: Riya Saxena <[email protected]> * Update public/plugin.ts Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 9e6066a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Jul 30, 2024
* side navigation changes for notifications * fix jest tests * navLinks changes * fixed the issues * fixed the issues * addressed the comments * addressed the comments * Update public/plugin.ts --------- (cherry picked from commit 9e6066a) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: SuZhou-Joe <[email protected]>
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
After side nav changes, when feature is enabled
When feature is disabled:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.