[Backport 2.x] Fix broken osd functional test repo (#189) #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moved constants to common folder Signed-off-by: Riya Saxena <[email protected]> * fix broken osd functionaltest Repo Signed-off-by: Riya Saxena <[email protected]> * fixing the UT's Signed-off-by: Riya Saxena <[email protected]> * fixing the UT's Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: Riya <[email protected]> (cherry picked from commit e597081)
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
Signed-off-by: Riya Saxena <[email protected]>
AWSHurneyt
changed the title
|
Based on the error on this line, I think you may need to rebase your branch to have PR #182 |
riysaxen-amzn
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan and
AWSHurneyt
as code owners
AWSHurneyt
approved these changes
Apr 26, 2024
praveensameneni
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR
Signed-off-by: Riya Saxena [email protected]
Signed-off-by: Riya Saxena [email protected]
Signed-off-by: Riya Saxena [email protected]
Signed-off-by: Riya Saxena [email protected]
Signed-off-by: Riya Saxena [email protected]
Signed-off-by: Riya [email protected]
(cherry picked from commit e597081)
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.