Backport binary installation workflow to 2.x #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SuZhou-Joe @Hailong-am can you help me get this merged? |
Hailong-am
approved these changes
Apr 26, 2024
Signed-off-by: Derek Ho <[email protected]>
SuZhou-Joe
force-pushed
the
backport-165
branch
from
8d6a274 to
395b23b
Compare
|
|
||
| on: [push, pull_request] | ||
| env: | ||
| OPENSEARCH_VERSION: '3.0.0' |
There was a problem hiding this comment.
OPENSEARCH_VERSION will overwrite by line 27 echo "OPENSEARCH_VERSION=$opensearch_version" >> $GITHUB_ENV, that's should not be a issue.
|
@derek-ho would you mind resolve the conflicts? |
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
xluo-aws,
gaobinlong,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan and
AWSHurneyt
as code owners
|
Looks like this was already merged here: https://github.com/opensearch-project/dashboards-notifications/pull/196/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #165
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.