-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update snapshot #168
update snapshot #168
Conversation
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
@@ -26,7 +26,7 @@ | |||
"@types/showdown": "^1.9.3", | |||
"enzyme-adapter-react-16": "^1.15.5", | |||
"jest-dom": "^4.0.0", | |||
"cypress": "^6.0.0" | |||
"cypress": "9.5.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
come from here https://github.com/opensearch-project/dashboards-notifications/actions/runs/8290160637/job/22687774853
Either we add --single-version=loose/ignore
in the CI or upgrade to same version will resolve the CI failure.
As ftr repo using the cypress 9.5.4, so i decide to upgrade to same version to avoid any potential version issue when copy the test to ftr repo and fix the version conflict here.
ERROR [single_version_dependencies] Multiple version ranges for the same dependency
were found declared across different package.json files. Please consolidate
those to match across all package.json files. Different versions for the
same dependency is not supported.
If you have questions about this please reach out to the operations team.
The conflicting dependencies are:
cypress
9.5.4 => opensearch-dashboards
^6.0.0 => notifications-dashboards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for the clarification.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 52 52
Lines 1497 1497
Branches 360 373 +13
=======================================
Hits 1298 1298
Misses 196 196
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* update snapshot Signed-off-by: Hailong Cui <[email protected]> * upgrade cypress to 9.5.4 Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 16f494e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* update snapshot * upgrade cypress to 9.5.4 --------- (cherry picked from commit 16f494e) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
update obsolete snapshot due to OUI upgrade
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.