Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update snapshot #168

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Mar 15, 2024

Description

update obsolete snapshot due to OUI upgrade

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
@@ -26,7 +26,7 @@
"@types/showdown": "^1.9.3",
"enzyme-adapter-react-16": "^1.15.5",
"jest-dom": "^4.0.0",
"cypress": "^6.0.0"
"cypress": "9.5.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

come from here https://github.com/opensearch-project/dashboards-notifications/actions/runs/8290160637/job/22687774853

Either we add --single-version=loose/ignore in the CI or upgrade to same version will resolve the CI failure.
As ftr repo using the cypress 9.5.4, so i decide to upgrade to same version to avoid any potential version issue when copy the test to ftr repo and fix the version conflict here.

ERROR [single_version_dependencies] Multiple version ranges for the same dependency
      were found declared across different package.json files. Please consolidate
      those to match across all package.json files. Different versions for the
      same dependency is not supported.

      If you have questions about this please reach out to the operations team.

      The conflicting dependencies are:

        cypress
          9.5.4 => opensearch-dashboards
          ^6.0.0 => notifications-dashboards

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for the clarification.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (0b5631a) to head (ba3d018).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   86.70%   86.70%           
=======================================
  Files          52       52           
  Lines        1497     1497           
  Branches      360      373   +13     
=======================================
  Hits         1298     1298           
  Misses        196      196           
  Partials        3        3           
Flag Coverage Δ
dashboards-notifications 86.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am Hailong-am merged commit 16f494e into opensearch-project:main Mar 15, 2024
8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2024
* update snapshot

Signed-off-by: Hailong Cui <[email protected]>

* upgrade cypress to 9.5.4

Signed-off-by: Hailong Cui <[email protected]>

---------

Signed-off-by: Hailong Cui <[email protected]>
(cherry picked from commit 16f494e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am pushed a commit that referenced this pull request Mar 15, 2024
* update snapshot



* upgrade cypress to 9.5.4



---------


(cherry picked from commit 16f494e)

Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants