Remove plugins pages for management overview registration

Signed-off-by: Hailong Cui <[email protected]>

.eslintrc.js

@@ -0,0 +1,33 @@
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+const LICENSE_HEADER = `
+/*
+ * Copyright OpenSearch Contributors
+ * SPDX-License-Identifier: Apache-2.0
+ */
+`
+
+module.exports = {
+  root: true,
+  extends: ['@elastic/eslint-config-kibana', 'plugin:@elastic/eui/recommended'],
+  rules: {
+    // "@osd/eslint/require-license-header": "off"
+  },
+  overrides: [
+    {
+      files: ['**/*.{js,ts,tsx}'],
+      rules: {
+        '@osd/eslint/require-license-header': [
+          'error',
+          {
+            licenses: [ LICENSE_HEADER ],
+          },
+        ],
+        "no-console": 0
+      }
+    }
+  ],
+};

package.json

@@ -11,7 +11,7 @@
   "scripts": {
     "osd": "node ../../scripts/osd",
     "opensearch": "node ../../scripts/opensearch",
-    "lint": "eslint .",
+    "lint": "node ../../scripts/eslint . && node ../../scripts/stylelint",
     "start": "yarn plugin_helpers start",
     "build": "yarn plugin_helpers build",
     "test:jest": "TZ=UTC ../../node_modules/.bin/jest --config ./test/jest.config.js",
@@ -34,4 +34,4 @@
     "async": "^3.2.3",
     "minimist": "^1.2.6"
   }
-}
+}

public/pages/Main/Main.tsx

@@ -21,7 +21,7 @@ import { CreateSESSender } from '../Emails/CreateSESSender';
 import { EmailGroups } from '../Emails/EmailGroups';
 import { EmailSenders } from '../Emails/EmailSenders';
 
-export enum Navigation {
+enum Navigation {
   Notifications = 'Notifications',
   Channels = 'Channels',
   EmailSenders = 'Email senders',
@@ -32,7 +32,7 @@ enum Pathname {
   Channels = '/channels',
 }
 
-interface MainProps extends RouteComponentProps {}
+type MainProps = RouteComponentProps;
 
 export interface MainState {
   availableChannels: Partial<typeof CHANNEL_TYPE>;

public/plugin.ts

@@ -3,6 +3,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+import { i18n } from '@osd/i18n';
 import {
   AppMountParameters,
   CoreSetup,
@@ -13,28 +14,28 @@ import {
 import {
   notificationsDashboardsPluginSetup,
   notificationsDashboardsPluginStart,
-  AppPluginStartDependencies,
+  NotificationsDashboardsSetupDeps,
 } from './types';
 import { PLUGIN_NAME } from '../common';
-import { Navigation } from "./pages/Main/Main";
-import { ROUTES } from "./utils/constants";
-import { ManagementOverViewPluginSetup } from "../../../src/plugins/management_overview/public";
-
-interface NotificationsDashboardsSetupDeps {
-  managementOverview?: ManagementOverViewPluginSetup;
-}
 
 export class notificationsDashboardsPlugin
   implements
     Plugin<
       notificationsDashboardsPluginSetup,
       notificationsDashboardsPluginStart
     > {
-  public setup(core: CoreSetup, { managementOverview }: NotificationsDashboardsSetupDeps): notificationsDashboardsPluginSetup {
+  private title = i18n.translate('notification.notificationTitle', {
+    defaultMessage: 'Notifications',
+  });
+
+  public setup(
+    core: CoreSetup,
+    { managementOverview }: NotificationsDashboardsSetupDeps
+  ): notificationsDashboardsPluginSetup {
     // Register an application into the side navigation menu
     core.application.register({
       id: PLUGIN_NAME,
-      title: 'Notifications',
+      title: this.title,
       category: DEFAULT_APP_CATEGORIES.management,
       order: 9060,
       async mount(params: AppMountParameters) {
@@ -50,25 +51,12 @@ export class notificationsDashboardsPlugin
     if (managementOverview) {
       managementOverview.register({
         id: PLUGIN_NAME,
-        title: 'Notifications',
+        title: this.title,
         order: 9060,
-        pages: [
-          {
-            title: Navigation.Channels,
-            url: `#${ROUTES.CHANNELS}`,
-            order: 100
-          },
-          {
-            title: Navigation.EmailSenders,
-            url: `#${ROUTES.EMAIL_SENDERS}`,
-            order: 200
-          },
-          {
-            title: Navigation.EmailGroups,
-            url: `#${ROUTES.EMAIL_GROUPS}`,
-            order: 300
-          },
-        ]
+        description: i18n.translate('notification.notificationDescription', {
+          defaultMessage:
+            'Connect with your communication service to receive notifications from supported OpenSearch plugins.',
+        }),
       });
     }
 

public/types.ts

@@ -4,6 +4,7 @@
  */
 
 import { NavigationPublicPluginStart } from '../../../src/plugins/navigation/public';
+import { ManagementOverViewPluginSetup } from "../../../src/plugins/management_overview/public";
 
 export interface notificationsDashboardsPluginSetup {}
 // eslint-disable-next-line @typescript-eslint/no-empty-interface
@@ -12,3 +13,7 @@ export interface notificationsDashboardsPluginStart {}
 export interface AppPluginStartDependencies {
   navigation: NavigationPublicPluginStart;
 }
+
+export interface NotificationsDashboardsSetupDeps {
+  managementOverview?: ManagementOverViewPluginSetup;
+}