This repository has been archived by the owner on Oct 7, 2022. It is now read-only.
Add deprecated notice in readme #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Li <[email protected]>
README.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| __NOTE:__ We have merged this plugin into [Observability Plugin](https://github.com/opensearch-project/trace-analytics/) since OpenSearch 1.2, please use notebooks in Observability Dashboards plugin. Thanks. | |||
There was a problem hiding this comment.
np- the "Thanks" appended at the end seems unnecessary/almost passive-aggressive?
davidcui1225
previously approved these changes
Nov 16, 2021
Signed-off-by: Joshua Li <[email protected]>
davidcui1225
previously approved these changes
Nov 16, 2021
probably because we didn't move to maven central, but this repo is deprecated and this might be the last PR so i don't think it's necessary to fix |
Sounds good- although with the new repo rules I can't remember if PRs can be merged in with a failing CI |
Signed-off-by: Joshua Li <[email protected]>
zhongnansu
approved these changes
Jan 12, 2022
ps48
approved these changes
Jan 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Li [email protected]
Description
Add deprecated notice in readme
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.