Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Look & Feel] Consistency and Density Changes #659

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

SheyGao
Copy link
Contributor

@SheyGao SheyGao commented Aug 20, 2024

Description

This PR makes consistency and density improvements, including:

  1. Using small context menus
  2. Using small tabs
  3. Using small List Groups
  4. Using small font size as normal paragraph font size through
  5. Using semantic headers (H1s on main pages, H2s on modals/flyouts) wrapped under
  6. Only using primary buttons for primary calls to action.
  7. Using Plus icons for create use cases and PlusInCricle icon for add use cases.
  8. Use Refresh Icon in “Update” buttons

Screenshots

Small Context Menus

Before After
Screenshot 2024-08-20 at 4 35 52 PM Screenshot 2024-08-20 at 4 36 16 PM

Small Tabs

Before After
Screenshot 2024-08-20 at 4 37 14 PM Screenshot 2024-08-20 at 4 37 53 PM
Screenshot 2024-08-20 at 4 38 31 PM Screenshot 2024-08-20 at 4 38 49 PM
Screenshot 2024-08-20 at 4 39 10 PM Screenshot 2024-08-20 at 4 39 26 PM

Small List Groups

Before After
Screenshot 2024-08-20 at 4 40 33 PM Screenshot 2024-08-20 at 4 41 00 PM

Standard Paragraph Text Size

Before After
Screenshot 2024-08-20 at 4 41 41 PM Screenshot 2024-08-20 at 4 42 12 PM
Screenshot 2024-08-20 at 4 44 48 PM Screenshot 2024-08-20 at 4 45 09 PM
Screenshot 2024-08-20 at 4 45 29 PM Screenshot 2024-08-20 at 4 45 46 PM

Semantic Headers

Before After
Screenshot 2024-08-20 at 4 48 14 PM Screenshot 2024-08-20 at 4 48 41 PM
Screenshot 2024-08-20 at 4 49 35 PM Screenshot 2024-08-20 at 4 49 50 PM
Screenshot 2024-08-20 at 4 50 08 PM Screenshot 2024-08-20 at 4 50 24 PM

Buttons for Actions

Before After
Screenshot 2024-08-20 at 4 51 44 PM Screenshot 2024-08-20 at 4 52 09 PM
Screenshot 2024-08-20 at 4 52 55 PM Screenshot 2024-08-20 at 4 53 07 PM
Screenshot 2024-08-20 at 4 53 40 PM Screenshot 2024-08-20 at 4 53 55 PM
Screenshot 2024-08-20 at 4 55 41 PM Screenshot 2024-08-20 at 4 56 00 PM

Plus Icon and PlusInCircle Icon

Before After
Screenshot 2024-08-20 at 4 57 06 PM Screenshot 2024-08-20 at 4 57 25 PM
Screenshot 2024-08-20 at 4 57 44 PM Screenshot 2024-08-20 at 4 58 00 PM

Refresh Icon in “Update” Buttons

Before After
Screenshot 2024-08-20 at 4 58 50 PM Screenshot 2024-08-20 at 4 59 04 PM

Changelog

  • refactor: [Look & Feel] Appearance Popover Button Change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SheyGao SheyGao force-pushed the look branch 2 times, most recently from 149d71a to cebb683 Compare August 20, 2024 22:09
@SheyGao SheyGao marked this pull request as ready for review August 21, 2024 00:00
VijayanB
VijayanB previously approved these changes Aug 22, 2024
@junqiu-lei
Copy link
Member

junqiu-lei commented Aug 22, 2024

Thanks @SheyGao, could you please check the failed unit test?

FAIL public/components/layer_control_panel/delete_layer_modal.test.tsx
  ● Test suite failed to run

    TypeError: Converting circular structure to JSON
        --> starting at object with constructor 'FiberNode'
        |     property 'stateNode' -> object with constructor 'FiberRootNode'
        --- property 'current' closes the circle
        at stringify (<anonymous>)

      at messageParent (../../node_modules/jest-worker/build/workers/messageParent.js:34:19)


Snapshot Summary
 › 1 snapshot failed from 1 test suite. Inspect your code changes or run `yarn run test:jest -u` to update them.

Test Suites: 2 failed, 20 passed, 22 total
Tests:       1 failed, 104 passed, 105 total
Snapshots:   1 failed, 11 passed, 12 total
Time:        31.331 s
Ran all test suites.

Shey Gao added 2 commits August 23, 2024 06:49
Signed-off-by: Shey Gao <[email protected]>
Signed-off-by: Shey Gao <[email protected]>
Signed-off-by: Shey Gao <[email protected]>
@VijayanB VijayanB merged commit ea8852a into opensearch-project:main Aug 23, 2024
8 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2024
* consistency changes

Signed-off-by: Shey Gao <[email protected]>

* fixed unit tests

Signed-off-by: Shey Gao <[email protected]>

* add changelog

Signed-off-by: Shey Gao <[email protected]>

---------

Signed-off-by: Shey Gao <[email protected]>
Co-authored-by: Shey Gao <[email protected]>
(cherry picked from commit ea8852a)
junqiu-lei pushed a commit that referenced this pull request Aug 23, 2024
* consistency changes

Signed-off-by: Shey Gao <[email protected]>

* fixed unit tests

Signed-off-by: Shey Gao <[email protected]>

* add changelog

Signed-off-by: Shey Gao <[email protected]>

---------

Signed-off-by: Shey Gao <[email protected]>
Co-authored-by: Shey Gao <[email protected]>
(cherry picked from commit ea8852a)

Co-authored-by: SheyGao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants