Support multi data source display in Maps app #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
martin-gaievski
as code owners
Signed-off-by: Junqiu Lei <[email protected]>
BionIT
reviewed
Apr 18, 2024
Signed-off-by: Junqiu Lei <[email protected]>
|
The cypress CI failure is known issue unrelated to this PR. |
BionIT
approved these changes
Apr 18, 2024
VijayanB
approved these changes
Apr 19, 2024
martin-gaievski
approved these changes
Apr 19, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-611-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f325212eb75c491b1b9e715403732d810197c869
# Push it to GitHub
git push --set-upstream origin backport/backport-611-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
junqiu-lei
added a commit
to junqiu-lei/dashboards-maps
that referenced
this pull request
Apr 22, 2024
* Support multi data source display in Maps app Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit f325212) Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
added a commit
that referenced
this pull request
Apr 22, 2024
* Support multi data source display in Maps app (cherry picked from commit f325212) Signed-off-by: Junqiu Lei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support multi data source display in Maps app. In maps list page, it will display all available data source. In maps visualization page, it will display all data sources in using.
Demo
Screen.Recording.2024-04-17.at.1.57.21.PM.mov
Test
Will add test in another PR in https://github.com/opensearch-project/opensearch-dashboards-functional-test which can mock remote data source.
Issues Resolved
Part of #584
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.