-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken build and failing tests #572
Fix broken build and failing tests #572
Conversation
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
e702c8d
to
fe1156f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
=======================================
Coverage 41.36% 41.36%
=======================================
Files 53 53
Lines 1789 1789
Branches 330 328 -2
=======================================
Hits 740 740
Misses 1019 1019
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
@ryanbogan the CI is still failing. |
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Tests passed for cypress but the upload step after is failing |
@ryanbogan Let's explicitly add cypress videos enabled https://github.com/junqiu-lei/dashboards-maps/blob/30d0ee2154b1e2629af359c788f66d4436eda68b/cypress.config.js#L4 |
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
CI failure is environment based on Windows only, and all cypress e2e tests are passing on ubuntu-latest. I also see the same failure on security-analytics dashboard plugin, which also runs Windows tests, so this might not be able to be fixed from our plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-572-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fdb4d22d81be6c07d607882577f7a6addba2f1cc
# Push it to GitHub
git push --set-upstream origin backport/backport-572-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@ryanbogan backport failed |
One of the classes is not present in 2.x. I'll raise manual backport |
Description
Fixes the broken build due to a change in babel.
Fixes unit tests by updating expected snapshot that changed due to upstream changes.
Fixes integration test by adding wait before selecting colors.
Changes Cypress test browser to electron in the CI, because the latest version chrome browser used higher memory/CPU which causes the workflow to fail
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.