Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build and failing tests #572

Merged
merged 19 commits into from
Jan 24, 2024

Conversation

ryanbogan
Copy link
Member

@ryanbogan ryanbogan commented Jan 10, 2024

Description

Fixes the broken build due to a change in babel.
Fixes unit tests by updating expected snapshot that changed due to upstream changes.
Fixes integration test by adding wait before selecting colors.
Changes Cypress test browser to electron in the CI, because the latest version chrome browser used higher memory/CPU which causes the workflow to fail

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Bogan <[email protected]>
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f75b230) 41.36% compared to head (561344b) 41.36%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   41.36%   41.36%           
=======================================
  Files          53       53           
  Lines        1789     1789           
  Branches      330      328    -2     
=======================================
  Hits          740      740           
  Misses       1019     1019           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Bogan <[email protected]>
@navneet1v
Copy link
Collaborator

@ryanbogan the CI is still failing.

@ryanbogan
Copy link
Member Author

Tests passed for cypress but the upload step after is failing

@junqiu-lei
Copy link
Member

Tests passed for cypress but the upload step after is failing

@ryanbogan Let's explicitly add cypress videos enabled https://github.com/junqiu-lei/dashboards-maps/blob/30d0ee2154b1e2629af359c788f66d4436eda68b/cypress.config.js#L4

Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
@ryanbogan
Copy link
Member Author

ryanbogan commented Jan 23, 2024

CI failure is environment based on Windows only, and all cypress e2e tests are passing on ubuntu-latest. I also see the same failure on security-analytics dashboard plugin, which also runs Windows tests, so this might not be able to be fixed from our plugin.

Copy link
Member

@junqiu-lei junqiu-lei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@junqiu-lei junqiu-lei merged commit fdb4d22 into opensearch-project:main Jan 24, 2024
10 of 11 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-572-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fdb4d22d81be6c07d607882577f7a6addba2f1cc
# Push it to GitHub
git push --set-upstream origin backport/backport-572-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-572-to-2.x.

@junqiu-lei
Copy link
Member

@ryanbogan backport failed

@ryanbogan
Copy link
Member Author

@ryanbogan backport failed

One of the classes is not present in 2.x. I'll raise manual backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants