Update snap to pass unit test #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junqiu Lei <[email protected]>
junqiu-lei
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
martin-gaievski
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #467 +/- ##
=======================================
Coverage 41.36% 41.36%
=======================================
Files 53 53
Lines 1789 1789
Branches 328 328
=======================================
Hits 740 740
Misses 1019 1019
Partials 30 30 |
heemin32
approved these changes
Sep 5, 2023
navneet1v
approved these changes
Sep 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2023
Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit d58db3b)
junqiu-lei
added a commit
that referenced
this pull request
Sep 5, 2023
Signed-off-by: Junqiu Lei <[email protected]> (cherry picked from commit d58db3b) Co-authored-by: Junqiu Lei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update snap to pass unit test to 2.x branch, since the node version is different between main and 2.x from OSD
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.