Allow filtering geoshape fields around map extent (#452)

From 2.9, geoshape supports geo bounding box. Hence, remove the constraint that disables geo bounding box for non geopoint fields. Signed-off-by: Vijayan Balasubramanian <[email protected]>
opensearch-project · Aug 6, 2023 · a4e92a0 · a4e92a0
1 parent 57c225a
commit a4e92a0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,8 +12,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 ### Maintenance
 ### Refactoring
 
-## [Unreleased 2.x](https://github.com/opensearch-project/dashboards-maps/compare/2.8...2.x)
+## [Unreleased 2.x](https://github.com/opensearch-project/dashboards-maps/compare/2.9...2.x)
 ### Features
+* Allow filtering geo_shape fields around map extent ([#452](https://github.com/opensearch-project/dashboards-maps/pull/452))
 
 ### Enhancements
 

diff --git a/public/components/layer_config/documents_config/document_layer_source.tsx b/public/components/layer_config/documents_config/document_layer_source.tsx
@@ -355,7 +355,6 @@ export const DocumentLayerSource = ({
           <EuiFormRow>
             <EuiCheckbox
               id={`${selectedLayerConfig.id}-bounding-box-filter`}
-              disabled={selectedLayerConfig.source.geoFieldType !== 'geo_point'}
               label={'Only request data around map extent'}
               checked={selectedLayerConfig.source.useGeoBoundingBoxFilter ? true : false}
               onChange={onToggleGeoBoundingBox}

diff --git a/public/model/layerRenderController.ts b/public/model/layerRenderController.ts
@@ -167,13 +167,12 @@ const getGeoBoundingBoxFilter = (
   maplibreRef: MaplibreRef
 ): GeoBoundingBoxFilter => {
   const geoField = mapLayer.source.geoFieldName;
-  const geoFieldType = mapLayer.source.geoFieldType;
 
   // geo bounding box query supports geo_point fields
   const mapBounds: GeoBounds = getBounds(maplibreRef.current!);
   const meta: FilterMeta = {
     alias: null,
-    disabled: !mapLayer.source.useGeoBoundingBoxFilter || geoFieldType !== 'geo_point',
+    disabled: !mapLayer.source.useGeoBoundingBoxFilter,
     negate: false,
     type: FILTERS.GEO_BOUNDING_BOX,
   };