Add deletion to Workflow List page table #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
joshpalis
approved these changes
Feb 29, 2024
dbwiddis
approved these changes
Feb 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 7043c11)
ohltyler
added a commit
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 7043c11) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a delete action to the table to delete the corresponding workflow, and a few other minor improvements to the table. Specifically:
actionscolumn with delete functionalityloadingredux field to display a spinner when fetching workflowsDemo video:
demo-229.webm
Issues Resolved
Resolves #70
Resolves #65
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.