-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial Flow Framework APIs; connect to Workflow List #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
February 28, 2024 20:41
ohltyler
changed the title
Add initial Flow Framework APIs; connect to Detector List
Add initial Flow Framework APIs; connect to Workflow List
Feb 28, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
Ignoring lint workflow as this is tagged as |
dbwiddis
approved these changes
Feb 28, 2024
amitgalitz
approved these changes
Feb 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 0362c6b)
ohltyler
added a commit
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 0362c6b) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following APIs to be accessible on client-side:
The Search Workflows API has been tested end-to-end and integrated with the redux store to persist formatted versions of the fetched workflows to be visible on the UI - currently it's been integrated into the Workflow List page. TODOs for e2e testing of the other APIs have been added and will be an ongoing effort as more UI is added where these APIs will be invoked.
Issues Resolved
Makes progress on #70 - leaving open until the workflow list items are finalized which may require more API calls to get workflow state, for example.
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.