Add node deletion functionality in Workspace #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
joshpalis
approved these changes
Oct 16, 2023
jackiehanyang
approved these changes
Oct 16, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 52e5cec)
ohltyler
added a commit
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 52e5cec) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a delete button to the header in the workflow component. Implements
deleteNode()to remove the node and any related edges viareactFlowInstancecontext. Updates Workspace state as well (see video ofSavebutton becoming available after deletion). Note that in order to delete, we need to propagate the ID into thedatafield of the ReactFlow component. We do this via a newinitComponentData()fn to populate instance-specific data, such as ID. There may be more of these types of fields in the future, so we leave the new interface and fn generic.Also cleans up the layout slightly to more closely align with UX mockups.
Demo video:
screen-capture.16.webm
Issues Resolved
Makes progress on #10 , #16
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.