Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc improvements #540

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Misc improvements #540

merged 6 commits into from
Dec 17, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Dec 17, 2024

Description

Small PR with few improvements:

  • always show the query in the search tab. if updated from the default configured query (if in search context), show a button to revert back
  • add loading state to the search button to prevent overloading, and for visibility if searches take a long time (e.g., RAG flows)
  • makes 'OverrideQueryModal' consistent with other modals by persisting temporary form s.t. query is only updated if users explicitly save
  • adds check for JSONArray form types to validate on byte size; this prevents hitting OSD REST request limits when executing APIs, such as ingest. For example, adding byte64 encodings in ingest may not exceed the already-defined doc count of 1000, but may exceed the byte count, and thus fail at runtime. This prevents even setting the docs field to something that would later fail, and provides detailed information in the error message.
  • tunes placeholder value for output map transforms where "No transformation" is selected
  • makes default input/output entries consistent when adding new, by setting default transform types to "Field" and "No transformation", respectively
  • add a JSONPath examples table component. Not used yet, as UX is still being finalized for this part. Will be accessible in some tooltips / extra information somewhere.

Demo video showing search changes:

screen-capture.12.webm

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler ohltyler changed the title Improve search and loading state Misc improvements Dec 17, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler ohltyler marked this pull request as ready for review December 17, 2024 20:18
@ohltyler ohltyler merged commit d1be4db into opensearch-project:main Dec 17, 2024
6 of 7 checks passed
@ohltyler ohltyler deleted the nit-fixes-6 branch December 17, 2024 21:36
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 17, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit d1be4db)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler pushed a commit that referenced this pull request Dec 17, 2024
(cherry picked from commit d1be4db)

Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants