-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support inserting template vars at cursor position; improve RAG preset #526
Merged
saimedhi
merged 7 commits into
opensearch-project:main
from
ohltyler:improve-template-vars
Dec 12, 2024
Merged
Support inserting template vars at cursor position; improve RAG preset #526
saimedhi
merged 7 commits into
opensearch-project:main
from
ohltyler:improve-template-vars
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
…types Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
December 12, 2024 00:59
ohltyler
changed the title
Support inserting template vars at cursor position; other minor improvements
Support inserting template vars at cursor position; improve RAG preset
Dec 12, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
saimedhi
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
saimedhi
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
#526) * Improve RAG preset prompt defaults Signed-off-by: Tyler Ohlsen <[email protected]> * Change prompt vars to insert at editor cursor position Signed-off-by: Tyler Ohlsen <[email protected]> * Fix spacing in configure prompt modal Signed-off-by: Tyler Ohlsen <[email protected]> * Improve default empty vals for input output map transforms Signed-off-by: Tyler Ohlsen <[email protected]> * handle npe; add check to block showing resources for custom workflow types Signed-off-by: Tyler Ohlsen <[email protected]> * add check to handle empty or missing ui_metadata Signed-off-by: Tyler Ohlsen <[email protected]> * fix UT Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit b613ce3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saimedhi
pushed a commit
that referenced
this pull request
Dec 12, 2024
#526) (#527) * Improve RAG preset prompt defaults * Change prompt vars to insert at editor cursor position * Fix spacing in configure prompt modal * Improve default empty vals for input output map transforms * handle npe; add check to block showing resources for custom workflow types * add check to handle empty or missing ui_metadata * fix UT --------- (cherry picked from commit b613ce3) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mixed-bag PR, includes the following:
Demo video covering most of the changes listed above:
screen-capture.4.webm
Issues Resolved
N/A
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.