Improve search response rendering; other minor fixes #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
added
backport 2.x
workflow editor
Roadmap:Ease of Use
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
saimedhi
approved these changes
Dec 11, 2024
Nothing is finalized, if that decision is made will be in a separate pr, yes. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 72c32e6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Dec 11, 2024
(cherry picked from commit 72c32e6) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR primarily improves the search response rendering. Instead of a single JSON editor view showing the list of _sources from the response, now offer 2 modes: 1/ a more structured view of the sources in a tabular format with pagination to look through the data, or 2/ a raw JSON view which shows the full response. This ensures that any data users are interested outside of the _source hits (e.g., aggregations, ext field values, etc.) is still accessible.
Implementation details:
Resultscomponent and sub-components containing the new rendering optionsResultscomponent accessible in the edit query modal and the query tab of the Inspector, which is the 2 places search is supportedDemo video, showing the updates to the edit query modal and the query panel in Inspector:
screen-capture.1.webm
Issues Resolved
--
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.