Clean up obj serialization; set up save workflow stub fns #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
ohltyler
force-pushed
the
generate-template-2
branch
from
def307a to
1d8aac3
Compare
|
Rebased to resolve merge conflicts |
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
force-pushed
the
generate-template-2
branch
from
1d8aac3 to
a989219
Compare
dbwiddis
approved these changes
Oct 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit f30ac98)
ohltyler
added a commit
that referenced
this pull request
Oct 6, 2023
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit f30ac98) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a few different things:
Workflowserialization in a few different ways: 1/ We now store the reactflow state underworkspaceFlowStatefield in aWorkflow. We do some post-processing on the nodes so we don't store unnecessary data in the state. 2/ Serialize the workspace components (knn index, text embedding processor, etc.) by converting class -> obj. To do this we add atoObj()fn in a base component class that all of the component classes extend. We may have future utility functions added here so this sets that up.componentsfield from theworkspacereducer, since we simply utilize the ReactFlowInstance for keeping this state.setDirty()/removeDirtyredux fns when a node or edge is added (deletions are TBD since there is no UX design on this part yet). See demo video below, where the 'save' button is only clickable when there is a change in the workspace state (adding an edge), and gets disabled after it has been "saved":screen-capture.13.webm
Issues Resolved
Makes progress on #10, #16, #18
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.