Improve input/output transformation configuration #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set up the config -> form -> schema -> template transformations for input_map Signed-off-by: Tyler Ohlsen <[email protected]> * Handle empty casse Signed-off-by: Tyler Ohlsen <[email protected]> * Add new input type selector Signed-off-by: Tyler Ohlsen <[email protected]> * Fix bug of model interface not autopopulating in map Signed-off-by: Tyler Ohlsen <[email protected]> * Support preset templates Signed-off-by: Tyler Ohlsen <[email protected]> * Dynamically render forms; edge case handling of empty docs Signed-off-by: Tyler Ohlsen <[email protected]> * Add bucketing logic and add to model config if applicable Signed-off-by: Tyler Ohlsen <[email protected]> * Set up new configure_template_modal; add config button when template type selected Signed-off-by: Tyler Ohlsen <[email protected]> * Add nested form state in new template modal Signed-off-by: Tyler Ohlsen <[email protected]> * Update layout Signed-off-by: Tyler Ohlsen <[email protected]> * Update template val form config to support subvars Signed-off-by: Tyler Ohlsen <[email protected]> * Add multi input var component & form integration Signed-off-by: Tyler Ohlsen <[email protected]> * Add var copying into input var list Signed-off-by: Tyler Ohlsen <[email protected]> * Update spacing Signed-off-by: Tyler Ohlsen <[email protected]> * Add fetching source data functionality Signed-off-by: Tyler Ohlsen <[email protected]> * Fix some spacing; add output jsonfield Signed-off-by: Tyler Ohlsen <[email protected]> * committing but broken Signed-off-by: Tyler Ohlsen <[email protected]> * Show transformed prompt Signed-off-by: Tyler Ohlsen <[email protected]> * add spacer Signed-off-by: Tyler Ohlsen <[email protected]> * Add nested template vars to input map Signed-off-by: Tyler Ohlsen <[email protected]> * Set up base expression modal Signed-off-by: Tyler Ohlsen <[email protected]> * Get expression modal working Signed-off-by: Tyler Ohlsen <[email protected]> * Add dynamic rendering if template or expression is populated Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
added
enhancement
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
|
I will update the tutorial in a later PR. |
|
There will also be minor tuning to the preview display values for the different input/output transforms, and some helper text, helper examples of JSONPath, etc. to be added in later PRs. This is all being finalized from UX. |
|
The feature branch has been tested and is working fine without breaking any existing functionality. I'm ok to merge it into the main branch. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit a148ea5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Nov 27, 2024
(cherry picked from commit a148ea5) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR merges the
feature/new-transformfeature branch tomain. The primary changes are:This changes how the configs for input/output transforms are persisted. Hence, old workflows created with the UI will fail.
Testing
Tested several use cases and verified the modals work as expected, including the presets, using connector / model configs based off of the tutorial
Issues resolved
Closes #491
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.