Fix preset output map configs for ML processors #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
ohltyler
changed the title
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
force-pushed
the
output-map-bug-fixes
branch
from
96b01c9 to
291be9d
Compare
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
saimedhi
approved these changes
Nov 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 0c89ccc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit 0c89ccc) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent PRs have reversed the way we persist the form values for the output map. A few util fns for generating preset mappings, transforms, etc. had been left behind. This PR fixes the outdated logic. Tested with several variations of vector search use cases to verify the prefilled data works as expected.
Also, fixes a bug of array outputs from JSONPath transforms being indexed different based on ML processor output vs. vanilla JSONPath output - we replicate the logic to be consistent with ML processors to prevent user confusion, such that the example transform is the same as the indexed transform when performing actual ingest/search.
Also, removes the extra logic that hides the 'query_template' field for ML search request processors. Instead, just expose it as a normal advanced setting. Still leaves the dedicated modal for configuring the query override.
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.