Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Integration Tests Workflow #426

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

saimedhi
Copy link
Collaborator

@saimedhi saimedhi commented Oct 14, 2024

Description

Issues Resolved

Related to #22

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi
Copy link
Collaborator Author

Ready for review. Please do not merge until Flow Framework Dashboards tests are added to opensearch-dashboards-functional-test repo. Currently pulling tests from my fork.


 name: Checkout Dashboards Functional Test Repo
        uses: actions/checkout@v2
        with:
          path: opensearch-dashboards-functional-test
          repository: saimedhi/opensearch-dashboards-functional-test
          ref: add_FF_PR
          fetch-depth: 0

@saimedhi
Copy link
Collaborator Author

@ohltyler, Tests are flaky. Tested the failing test locally.

Screenshot 2024-10-16 at 11 32 53 AM Screenshot 2024-10-16 at 11 33 21 AM Screenshot 2024-10-16 at 11 33 35 AM Screenshot 2024-10-16 at 11 33 43 AM Screenshot 2024-10-16 at 11 33 51 AM

@saimedhi saimedhi marked this pull request as ready for review October 16, 2024 18:41
@ohltyler
Copy link
Member

Let's see what we can do to get them not flaky in these test runners. Not opposed to increasing the timeout if that's the bottleneck happening.

@saimedhi
Copy link
Collaborator Author

Hi @ohltyler, fixed all the flakiness in the integration tests where-ever I noticed.

@saimedhi
Copy link
Collaborator Author

@ohltyler, shall we get this workflow merged.

Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ohltyler ohltyler merged commit e82acac into opensearch-project:main Oct 21, 2024
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 21, 2024
Signed-off-by: saimedhi <[email protected]>
(cherry picked from commit e82acac)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ohltyler
Copy link
Member

You will probably need to do a manual backport to update the versions in the CI workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants