Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve prompt config UX; support JSONPath bug fix #403

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Oct 1, 2024

Description

Misc improvements PR:

  • improves the logic on when to expose the "Configure prompt" section in the ML processor configs. Rather than exposing by default for ML search response processors, instead only expose if there is a present 'prompt` parameters via the connector blueprint, regardless of context (ingest,search req, search resp). In general, this will require some consistency on the expected blueprints to contain such field for such use cases - ongoing discussions with ML team to sort this part out.
  • supports / is consistent with the bug fix in ML ingest processors, (see here)such that we do not always default to an array obj. Updates the underlying jsonpath call from query -> value, where value returns the first hit in the target obj, instead of wrapping all hits in an arr.
  • Minor wording improvements of the 'Tools' tabs
  • changing hardcoded prompt field to a constant. we may have more, and/or have a regex for determining when a connector has a configurable "prompt"/"prompt template" etc. (tracked via Make prompt parameter field more flexible #393)

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@saimedhi saimedhi merged commit a7a0264 into opensearch-project:main Oct 2, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 2, 2024
…gest processor bug fix (#403)

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit a7a0264)
@ohltyler ohltyler deleted the updates-2 branch October 2, 2024 18:39
@saimedhi
Copy link
Collaborator

saimedhi commented Oct 2, 2024

Hello @ohltyler, would it be possible to provide a screen recording showcasing any changes from the user's perspective?

saimedhi pushed a commit that referenced this pull request Oct 2, 2024
…gest processor bug fix (#403) (#405)

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit a7a0264)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants