-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support relevant form toggling in advanced transform modals #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz,
jackiehanyang,
minalsha and
saimedhi
as code owners
September 17, 2024 16:32
4 tasks
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
changed the title
Support one-to-one/many-to-one toggling; add relevant forms in transform modals
Support relevant form toggling in advanced transform modals
Sep 17, 2024
ohltyler
added
rapid
Roadmap:Ease of Use
Project-wide roadmap label
advanced transform
labels
Sep 17, 2024
saimedhi
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Changes Looks good to me. From the UI, one_to_one toggling on the input transform, and full_response_path toggling on the output transform seem to work rightly. Thank you, Tyler.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Support one-to-one on input Signed-off-by: Tyler Ohlsen <[email protected]> * dynamic description; add field; add input docs limit Signed-off-by: Tyler Ohlsen <[email protected]> * expose onetoone on input transform (search resp) Signed-off-by: Tyler Ohlsen <[email protected]> * Onboard full_response_path for output (ingest, search resp) Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 4e2445d)
ohltyler
added a commit
that referenced
this pull request
Sep 17, 2024
) Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 4e2445d) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds specific, relevant forms to be exposed in the advanced transform modals, such that users can toggle and test directly within the modal, instead of navigating to/from the advanced settings fields. Specifically:
one_to_one
toggling on INPUT transform for SEARCH RESPONSE only. This changes what the source input will be (single value vs. array of values)full_response_path
toggling on OUTPUT transforms for INGEST / SEARCH RESPONSE only. This changes what the source output will be (nested model response vs. full model response)More details
one_to_one
is false). In this scenario, we collapse the values from all of the documents into a single list, to pass as a single parameter for one inference call via the ML processorgenerateTransform
to support the above use case ^override
field for search resp processorDemo video, showing
one_to_one
toggling on the input transform, andfull_response_path
toggling on the output transform. Note the model input selector in the output field changes from a selector whenfalse
, to a freeform text whentrue
. This is because when it istrue
, the full model response path is passed, and users must write custom JSON path to parse out the relevant values they need.screen-capture.24.webm
Issues Resolved
Resolves #367
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.