workflow_detail unit tests #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: saimedhi <[email protected]>
saimedhi
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz,
jackiehanyang and
minalsha
as code owners
minalsha
approved these changes
Sep 4, 2024
ohltyler
reviewed
Sep 4, 2024
ohltyler
reviewed
Sep 4, 2024
ohltyler
reviewed
Sep 4, 2024
ohltyler
reviewed
Sep 5, 2024
Signed-off-by: saimedhi <[email protected]>
workflow_detail tests
Signed-off-by: saimedhi <[email protected]>
workflow_detail tests
Signed-off-by: saimedhi <[email protected]>
Signed-off-by: saimedhi <[email protected]>
workflow_detail tests
ohltyler
reviewed
Sep 5, 2024
ohltyler
reviewed
Sep 5, 2024
Signed-off-by: saimedhi <[email protected]>
workflow_detail tests
ohltyler
reviewed
Sep 6, 2024
| return <WorkflowDetail setActionMenu={jest.fn()} {...props} />; | ||
| }} | ||
| /> | ||
| <Redirect from="/" to={`/workflow/${workflowId}`} /> |
There was a problem hiding this comment.
wondering why we need this redirect? Can't we specify the path directly on line 44?
There was a problem hiding this comment.
- @ohltyler, Removed Redirect and instead adding initialEntries within the history.
- And also below path should not be removed. Whenever URL matches the below pattern then workflowId will be dynamically obtained from URL. Similar to the actual use case of workflowDetail Component.
path="/workflow/:workflowId"
|
LGTM on those checks. But to complete the basic UT, we should check any general functionality based on the scope of each component as well. Some things I can think of:
Overall, I'd recommend playing around with each page and trying to cover more basic expectations, besides strictly reading for text fields being visible. You can refer to the detector list test suite in AD for some detailed examples. I don't think we need to start this extreme, but should check that the base functionality is there across the whole page. |
ohltyler
approved these changes
Sep 6, 2024
Signed-off-by: saimedhi <[email protected]>
workflow_detail tests
ohltyler
approved these changes
Sep 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
* workflow_detail tests Signed-off-by: saimedhi <[email protected]> * workflow_detail tests Signed-off-by: saimedhi <[email protected]> * workflow_detail tests Signed-off-by: saimedhi <[email protected]> * workflow_detail tests Signed-off-by: saimedhi <[email protected]> * workflow_detail tests Signed-off-by: saimedhi <[email protected]> * workflow_detail tests Signed-off-by: saimedhi <[email protected]> * workflow_detail tests Signed-off-by: saimedhi <[email protected]> * workflow_detail tests Signed-off-by: saimedhi <[email protected]> --------- Signed-off-by: saimedhi <[email protected]> (cherry picked from commit afb45d6)
ohltyler
pushed a commit
that referenced
this pull request
Sep 6, 2024
Signed-off-by: saimedhi <[email protected]> (cherry picked from commit afb45d6) Co-authored-by: Sai Medhini Reddy Maryada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Related to #95
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.