Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic preset queries; onboard hybrid/multimodal search use cases #302

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

ohltyler
Copy link
Member

Description

This PR is a start to improve the user experience for existing, basic neural-search-variation use cases:

  1. Onboards hybrid and multimodal use cases as options
  2. Provides preset, sample queries for users to use. Currently just basic ones for each use case.

More details:

  • sets up and defines constants for some basic queries using the neural clause based on different use cases
  • refactors the query editing modal into a standalone EditQueryModal component to separately handle state
  • minor tune to the Run query button to allow it to run, even if no search processors are defined
  • basic preset UI config logic in new_workflow/utils for the new use cases, including setting the default query
  • adds filters for the new use case types in the workflow list page

Notes:

  • the hybrid query use case should have a normalization processor set by default. This is a complex processor not yet onboarded as an option yet, will be done in a separate PR
  • depending on final UX, may have some more automated logic around populating some of the placeholders in the preset queries and/or expanding the number of preset queries per use case. This may also mean some dynamic form inputs for users to fill in placeholders, and let the frontend handle generation of the final query.

Demo video, showing the different use cases, and the added dropdown in the "Edit query" modal to select from some presets. For preset use cases, they are set by default.

screen-capture.1.webm

Issues Resolved

Makes progress on #23

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler ohltyler merged commit cc54976 into opensearch-project:main Aug 20, 2024
6 checks passed
@ohltyler ohltyler deleted the preset-queries branch August 20, 2024 22:51
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 20, 2024
ohltyler added a commit that referenced this pull request Aug 20, 2024
…302) (#303)

Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit cc54976)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants