Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize edit flow for ingest inputs #202

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Jul 8, 2024

Description

This PR finalizes all create and edit states for the ingest flow configuration. Specifically:

  • updates buttons to be consistent, and be enabled/disabled based on the form and edit state
  • updates edit flow to have a 'Delete resources' button, which opens a confirmation modal to confirm deletion. if deletion is selected, revert to the create state, but defaulted to the 'skip' option.
  • updates search flow to have a dynamic index configuration; if ingest is configured, enforce the search flow is against the configured index. if ingest is not configured/skipped, then provide a dropdown listing out available indices the user can select to run the search flow against

Demo video showing the create and edit states, new buttons, resource deletion confirmation, and the 2 different states of the configured index on the search flow:

screen-capture.48.webm

Issues Resolved

Makes progress on #23

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz
Copy link
Member

On the pop-up for delete confirmation should we mention which resources we are deleting, or mention when we are deleting an index?

@ohltyler
Copy link
Member Author

ohltyler commented Jul 9, 2024

On the pop-up for delete confirmation should we mention which resources we are deleting, or mention when we are deleting an index?

Current mocks don't show those specifics. We can always tune later. We don't have any finalized wording.

@ohltyler ohltyler merged commit 73a2edd into opensearch-project:main Jul 9, 2024
9 checks passed
@ohltyler ohltyler deleted the finalized-edit-flow branch July 9, 2024 16:17
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 9, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 73a2edd)
ohltyler added a commit that referenced this pull request Jul 9, 2024
Signed-off-by: Tyler Ohlsen <[email protected]>
(cherry picked from commit 73a2edd)

Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants