Add invalid workflow state; support JSON doc uploads #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
amitgalitz and
jackiehanyang
as code owners
minalsha
approved these changes
Jun 27, 2024
dbwiddis
approved these changes
Jun 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2ef7e05)
ohltyler
added a commit
that referenced
this pull request
Jun 28, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 2ef7e05) Co-authored-by: Tyler Ohlsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR achieves 2 small things:
.jsonfiles only for now), and when loaded, populates the input form with its contents. Further guardrails, different filetypes, etc. have not been finalized.Demo showing the invalid state and the filepicker, and loading in a file
test.jsonthat contains the simple json{ "hello": "world" }screen-capture.47.webm
Issues Resolved
Makes progress on #23
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.